Source/core/css/resolver/ElementResolveContext.h - Issue 23819007: Have Node::document() return a reference instead of a pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/ElementResolveContext.h

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/ElementResolveContext.h

diff --git a/Source/core/css/resolver/ElementResolveContext.h b/Source/core/css/resolver/ElementResolveContext.h

index fcb43631ed5ffe9ee2398436cd26113a6b904c50..ebbe1cfe50f680aa7da2d158c435e8a89fa8bd4a 100644

--- a/Source/core/css/resolver/ElementResolveContext.h

+++ b/Source/core/css/resolver/ElementResolveContext.h

@@ -47,9 +47,8 @@ public:

explicit ElementResolveContext(Element*);

- // FIXME: This should return a reference.

- Document* document() const { return m_element->document(); }

- bool isDocumentElement() const { return m_element && m_element == m_element->document()->documentElement(); }

+ Document& document() const { return m_element->document(); }

+ bool isDocumentElement() const { return m_element && m_element == m_element->document().documentElement(); }

Element* element() const { return m_element; }

const ContainerNode* parentNode() const { return m_parentNode; }