Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: Source/core/dom/Node.h

Issue 23819007: Have Node::document() return a reference instead of a pointer (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/NamedNodeMap.cpp ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Node.h
diff --git a/Source/core/dom/Node.h b/Source/core/dom/Node.h
index 8157bfcb4e9e51ab97112a31545eaff3fd13c9a1..5aadeae401b461b158d7aacd1f310c7bdfa7db53 100644
--- a/Source/core/dom/Node.h
+++ b/Source/core/dom/Node.h
@@ -484,14 +484,12 @@ public:
// of a Document node.
Document* ownerDocument() const;
- // FIXME: This should return a reference.
- // Returns the document associated with this node. This method never returns 0.
- // A Document node returns itself.
- Document* document() const
+ // Returns the document associated with this node. A Document node returns itself.
+ Document& document() const
{
ASSERT(this);
ASSERT(documentInternal());
- return documentInternal();
+ return *documentInternal();
}
TreeScope* treeScope() const { return m_treeScope; }
« no previous file with comments | « Source/core/dom/NamedNodeMap.cpp ('k') | Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698