Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)

Created:
4 years, 3 months ago by maxbogue
Modified:
4 years, 3 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, rouslan+autofill_chromium.org, tfarina, hidehiko+watch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, pam+watch_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, chromium-apps-reviews_chromium.org, gcasto+watchlist_chromium.org, sync-reviews_chromium.org, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Convert DTCs to be not RefCounted and NonThreadSafe. This CL changes the sync DataTypeControllers to SupportWeakPtr instead of RefCountedDeleteOnMessageLoop, making them no longer thread safe. - DTCs are owned by the PSS map so they can no longer outlive PSS. - Remove the ui_thread parameter to DTC::ctors since it is no longer needed by RefCountedDeleteOnMessageLoop or thread checks. - Add the type parameter to DTC::ctor since so many subclasses stored it anyways; put it first because it's important. - All destructors become public. - All thread checks become DCHECK(CalledOnValidThread()); and many new ones have been added. - All callbacks are bound with weakptrs to make them safe. - Remove the unused TypedUrlDataTypeController::SetBackend. - Remove NonBlockingDataTypeController::BelongsToUIThread and ::RunOnUIThread as they are unnecessary. - Rename error_callback to dump_stack for clarity in the DTCs. This CL also includes http://crrev.com/2269103003: Splitting error handling code out of DataTypeControllers. - Move DataTypeErrorHandler* to //components/sync/api - Add DataTypeErrorHandlerImpl - Add DataTypeController::CreateErrorHandler - Factor some shared logic out of DTCs into DTEHI - Pass DataTypeErrorHandler as a unique_ptr instead of raw pointer These are going to be landed together because of a ref-cycle introduced by the error handling change that the WeakPtr change fixes. BUG=638771 Committed: https://crrev.com/fd43b4b98dab6bdd565dad4a89e9baf341281f58 Cr-Commit-Position: refs/heads/master@{#416754}

Patch Set 1 #

Patch Set 2 : Uncombined patch. #

Patch Set 3 : Rebase combined patch. #

Patch Set 4 : Uncombined patch. #

Total comments: 10

Patch Set 5 : Address comments (combined patch for bots). #

Total comments: 2

Patch Set 6 : Use ThreadChecker instead of NonThreadSafe. #

Total comments: 6

Patch Set 7 : Rebase, address comments, remove TestMessageLoop. #

Total comments: 56

Patch Set 8 : Address comments. #

Patch Set 9 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1160 lines, -1445 lines) Patch
M chrome/browser/supervised_user/supervised_user_sync_data_type_controller.h View 1 2 3 4 5 6 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 6 chunks +39 lines, -32 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.h View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -10 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.h View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -12 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.cc View 1 2 3 4 5 6 2 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.h View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h View 1 2 3 4 5 6 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc View 1 2 3 4 5 6 7 6 chunks +7 lines, -11 lines 0 comments Download
M components/autofill/core/browser/autofill_wallet_data_type_controller.h View 1 2 3 4 5 6 5 chunks +8 lines, -17 lines 0 comments Download
M components/autofill/core/browser/autofill_wallet_data_type_controller.cc View 1 2 3 4 5 6 6 chunks +18 lines, -29 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_data_type_controller.h View 1 2 3 4 5 6 1 chunk +3 lines, -5 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_data_type_controller.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_data_type_controller_unittest.cc View 2 4 4 chunks +7 lines, -5 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h View 1 2 3 4 5 6 2 chunks +3 lines, -8 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_profile_data_type_controller.cc View 5 chunks +15 lines, -17 lines 0 comments Download
M components/browser_sync/browser/profile_sync_components_factory_impl.h View 2 4 2 chunks +2 lines, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_components_factory_impl.cc View 2 4 9 chunks +55 lines, -45 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_autofill_unittest.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc View 2 4 5 chunks +12 lines, -7 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_startup_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service_typed_url_unittest.cc View 2 4 4 chunks +5 lines, -6 lines 0 comments Download
M components/browser_sync/browser/profile_sync_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/history/core/browser/history_delete_directives_data_type_controller.h View 1 2 3 4 5 6 2 chunks +3 lines, -5 lines 0 comments Download
M components/history/core/browser/history_delete_directives_data_type_controller.cc View 2 4 5 chunks +8 lines, -6 lines 0 comments Download
M components/history/core/browser/typed_url_data_type_controller.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -14 lines 0 comments Download
M components/history/core/browser/typed_url_data_type_controller.cc View 2 4 6 chunks +13 lines, -28 lines 0 comments Download
M components/password_manager/sync/browser/password_data_type_controller.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -6 lines 0 comments Download
M components/password_manager/sync/browser/password_data_type_controller.cc View 3 chunks +6 lines, -10 lines 0 comments Download
M components/search_engines/BUILD.gn View 2 4 1 chunk +1 line, -0 lines 0 comments Download
M components/search_engines/search_engine_data_type_controller.h View 1 2 3 4 5 6 1 chunk +5 lines, -10 lines 0 comments Download
M components/search_engines/search_engine_data_type_controller.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M components/search_engines/search_engine_data_type_controller_unittest.cc View 1 2 3 4 5 6 7 7 chunks +31 lines, -37 lines 0 comments Download
M components/sync/BUILD.gn View 1 2 3 4 5 6 7 8 4 chunks +5 lines, -3 lines 0 comments Download
A + components/sync/api/data_type_error_handler.h View 2 4 2 chunks +12 lines, -8 lines 0 comments Download
A components/sync/api/data_type_error_handler_impl.h View 2 4 1 chunk +53 lines, -0 lines 0 comments Download
A components/sync/api/data_type_error_handler_impl.cc View 2 4 1 chunk +46 lines, -0 lines 0 comments Download
A + components/sync/api/data_type_error_handler_mock.h View 2 4 2 chunks +9 lines, -7 lines 0 comments Download
A + components/sync/api/data_type_error_handler_mock.cc View 2 4 3 chunks +6 lines, -3 lines 0 comments Download
M components/sync/api/fake_model_type_change_processor.h View 2 4 2 chunks +4 lines, -2 lines 0 comments Download
M components/sync/api/fake_model_type_change_processor.cc View 2 4 1 chunk +1 line, -1 line 0 comments Download
M components/sync/api/model_type_change_processor.h View 2 4 2 chunks +4 lines, -3 lines 0 comments Download
M components/sync/api/model_type_service.h View 2 4 2 chunks +4 lines, -6 lines 0 comments Download
M components/sync/api/model_type_service.cc View 2 4 2 chunks +5 lines, -3 lines 0 comments Download
M components/sync/api/model_type_service_unittest.cc View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -4 lines 0 comments Download
D components/sync/core/data_type_error_handler.h View 2 4 1 chunk +0 lines, -38 lines 0 comments Download
M components/sync/core/shared_model_type_processor.h View 2 4 3 chunks +5 lines, -4 lines 0 comments Download
M components/sync/core/shared_model_type_processor.cc View 1 2 4 6 chunks +6 lines, -6 lines 0 comments Download
M components/sync/core/shared_model_type_processor_unittest.cc View 1 2 3 4 5 6 7 8 5 chunks +11 lines, -4 lines 0 comments Download
D components/sync/core/test/data_type_error_handler_mock.h View 2 4 1 chunk +0 lines, -38 lines 0 comments Download
M components/sync/core_impl/model_type_connector_proxy_unittest.cc View 1 2 3 4 5 6 7 8 3 chunks +2 lines, -3 lines 0 comments Download
D components/sync/core_impl/test/data_type_error_handler_mock.cc View 2 4 1 chunk +0 lines, -35 lines 0 comments Download
M components/sync/device_info/device_info_data_type_controller.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -5 lines 0 comments Download
M components/sync/device_info/device_info_data_type_controller.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M components/sync/device_info/device_info_data_type_controller_unittest.cc View 2 4 3 chunks +4 lines, -5 lines 0 comments Download
M components/sync/device_info/device_info_service_unittest.cc View 2 4 3 chunks +3 lines, -5 lines 0 comments Download
M components/sync/driver/change_processor.h View 2 4 3 chunks +6 lines, -3 lines 0 comments Download
M components/sync/driver/change_processor.cc View 2 4 2 chunks +6 lines, -3 lines 0 comments Download
M components/sync/driver/change_processor_mock.h View 2 4 2 chunks +3 lines, -9 lines 0 comments Download
M components/sync/driver/change_processor_mock.cc View 2 4 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/data_type_controller.h View 1 2 3 4 5 6 7 6 chunks +26 lines, -38 lines 0 comments Download
M components/sync/driver/data_type_controller.cc View 1 2 3 4 5 2 chunks +7 lines, -16 lines 0 comments Download
M components/sync/driver/data_type_controller_mock.h View 2 4 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/data_type_manager_impl_unittest.cc View 2 4 3 chunks +10 lines, -6 lines 0 comments Download
M components/sync/driver/directory_data_type_controller.h View 1 2 3 4 5 6 3 chunks +7 lines, -7 lines 0 comments Download
M components/sync/driver/directory_data_type_controller.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M components/sync/driver/fake_data_type_controller.h View 2 4 4 chunks +3 lines, -7 lines 0 comments Download
M components/sync/driver/fake_data_type_controller.cc View 1 2 4 9 chunks +17 lines, -15 lines 0 comments Download
M components/sync/driver/fake_generic_change_processor.h View 2 4 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/driver/fake_generic_change_processor.cc View 2 4 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/fake_sync_service.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/sync/driver/fake_sync_service.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/driver/frontend_data_type_controller.h View 1 2 3 4 5 6 7 4 chunks +10 lines, -21 lines 0 comments Download
M components/sync/driver/frontend_data_type_controller.cc View 1 2 4 10 chunks +37 lines, -46 lines 0 comments Download
M components/sync/driver/frontend_data_type_controller_mock.h View 2 4 3 chunks +1 line, -7 lines 0 comments Download
M components/sync/driver/frontend_data_type_controller_unittest.cc View 2 4 6 chunks +17 lines, -29 lines 0 comments Download
M components/sync/driver/generic_change_processor.h View 2 4 3 chunks +2 lines, -2 lines 0 comments Download
M components/sync/driver/generic_change_processor.cc View 2 4 16 chunks +33 lines, -33 lines 0 comments Download
M components/sync/driver/generic_change_processor_factory.h View 2 4 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/driver/generic_change_processor_factory.cc View 2 4 2 chunks +5 lines, -3 lines 0 comments Download
M components/sync/driver/generic_change_processor_unittest.cc View 2 4 5 chunks +3 lines, -4 lines 0 comments Download
M components/sync/driver/model_association_manager.h View 2 4 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/driver/model_association_manager.cc View 2 4 1 chunk +3 lines, -2 lines 0 comments Download
M components/sync/driver/model_association_manager_unittest.cc View 2 4 15 chunks +34 lines, -21 lines 0 comments Download
M components/sync/driver/non_blocking_data_type_controller.h View 1 2 3 4 5 6 3 chunks +7 lines, -26 lines 0 comments Download
M components/sync/driver/non_blocking_data_type_controller.cc View 1 2 3 4 12 chunks +30 lines, -54 lines 0 comments Download
M components/sync/driver/non_blocking_data_type_controller_unittest.cc View 1 2 3 4 5 6 7 8 10 chunks +26 lines, -37 lines 0 comments Download
M components/sync/driver/non_ui_data_type_controller.h View 1 2 3 4 5 6 4 chunks +8 lines, -11 lines 0 comments Download
M components/sync/driver/non_ui_data_type_controller.cc View 1 2 4 11 chunks +32 lines, -36 lines 0 comments Download
M components/sync/driver/non_ui_data_type_controller_mock.h View 2 4 3 chunks +1 line, -5 lines 0 comments Download
M components/sync/driver/non_ui_data_type_controller_unittest.cc View 1 2 3 4 17 chunks +34 lines, -42 lines 0 comments Download
M components/sync/driver/non_ui_model_type_controller.h View 1 2 3 4 5 6 1 chunk +4 lines, -10 lines 0 comments Download
M components/sync/driver/non_ui_model_type_controller.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -19 lines 0 comments Download
M components/sync/driver/non_ui_model_type_controller_unittest.cc View 1 2 3 4 5 6 7 8 5 chunks +8 lines, -15 lines 0 comments Download
M components/sync/driver/proxy_data_type_controller.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -15 lines 0 comments Download
M components/sync/driver/proxy_data_type_controller.cc View 1 2 3 4 5 6 7 6 chunks +14 lines, -22 lines 0 comments Download
M components/sync/driver/shared_change_processor.h View 2 4 6 chunks +9 lines, -7 lines 0 comments Download
M components/sync/driver/shared_change_processor.cc View 2 4 8 chunks +10 lines, -10 lines 0 comments Download
M components/sync/driver/shared_change_processor_unittest.cc View 2 4 4 chunks +4 lines, -4 lines 0 comments Download
M components/sync/driver/sync_api_component_factory.h View 2 4 3 chunks +2 lines, -2 lines 0 comments Download
M components/sync/driver/sync_api_component_factory_mock.h View 2 4 2 chunks +5 lines, -8 lines 0 comments Download
M components/sync/driver/sync_api_component_factory_mock.cc View 2 4 2 chunks +7 lines, -3 lines 0 comments Download
M components/sync/driver/sync_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/ui_data_type_controller.h View 1 2 3 4 5 6 4 chunks +9 lines, -17 lines 0 comments Download
M components/sync/driver/ui_data_type_controller.cc View 1 2 3 4 5 6 7 13 chunks +39 lines, -46 lines 0 comments Download
M components/sync/driver/ui_data_type_controller_unittest.cc View 1 2 3 4 5 6 6 chunks +21 lines, -6 lines 0 comments Download
M components/sync/driver/ui_model_type_controller.h View 1 2 3 4 5 6 1 chunk +4 lines, -10 lines 0 comments Download
M components/sync/driver/ui_model_type_controller.cc View 1 chunk +6 lines, -17 lines 0 comments Download
M components/sync/driver/ui_model_type_controller_unittest.cc View 1 2 3 4 5 6 7 8 5 chunks +9 lines, -23 lines 0 comments Download
M components/sync_bookmarks/bookmark_change_processor.h View 2 4 3 chunks +6 lines, -4 lines 0 comments Download
M components/sync_bookmarks/bookmark_change_processor.cc View 2 4 11 chunks +13 lines, -13 lines 0 comments Download
M components/sync_bookmarks/bookmark_data_type_controller.h View 1 2 3 4 5 6 1 chunk +4 lines, -9 lines 0 comments Download
M components/sync_bookmarks/bookmark_data_type_controller.cc View 2 4 5 chunks +10 lines, -10 lines 0 comments Download
M components/sync_bookmarks/bookmark_data_type_controller_unittest.cc View 1 2 4 5 chunks +3 lines, -7 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.h View 2 4 4 chunks +4 lines, -3 lines 0 comments Download
M components/sync_bookmarks/bookmark_model_associator.cc View 2 4 5 chunks +6 lines, -6 lines 0 comments Download
M components/sync_sessions/session_data_type_controller.h View 1 2 3 4 5 6 2 chunks +6 lines, -9 lines 0 comments Download
M components/sync_sessions/session_data_type_controller.cc View 2 4 8 chunks +15 lines, -15 lines 0 comments Download
M components/sync_sessions/session_data_type_controller_unittest.cc View 2 4 5 chunks +42 lines, -46 lines 0 comments Download
M components/sync_sessions/sessions_sync_manager.h View 2 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 50 (30 generated)
maxbogue
Pavel, Sky, PTAL! This is a big one but I think it's a really nice ...
4 years, 3 months ago (2016-08-30 18:44:38 UTC) #4
pavely
lgtm https://codereview.chromium.org/2289143003/diff/60001/components/sync/driver/non_blocking_data_type_controller.cc File components/sync/driver/non_blocking_data_type_controller.cc (right): https://codereview.chromium.org/2289143003/diff/60001/components/sync/driver/non_blocking_data_type_controller.cc#newcode36 components/sync/driver/non_blocking_data_type_controller.cc:36: DCHECK(CalledOnValidThread()); This is redundant. NonThreadSafe remembers owning thread ...
4 years, 3 months ago (2016-09-01 18:40:18 UTC) #7
maxbogue
https://codereview.chromium.org/2289143003/diff/60001/components/sync/driver/non_blocking_data_type_controller.cc File components/sync/driver/non_blocking_data_type_controller.cc (right): https://codereview.chromium.org/2289143003/diff/60001/components/sync/driver/non_blocking_data_type_controller.cc#newcode36 components/sync/driver/non_blocking_data_type_controller.cc:36: DCHECK(CalledOnValidThread()); On 2016/09/01 18:40:18, pavely wrote: > This is ...
4 years, 3 months ago (2016-09-01 20:23:48 UTC) #10
pavely
https://codereview.chromium.org/2289143003/diff/60001/components/sync/driver/non_blocking_data_type_controller.cc File components/sync/driver/non_blocking_data_type_controller.cc (right): https://codereview.chromium.org/2289143003/diff/60001/components/sync/driver/non_blocking_data_type_controller.cc#newcode36 components/sync/driver/non_blocking_data_type_controller.cc:36: DCHECK(CalledOnValidThread()); On 2016/09/01 20:23:47, maxbogue wrote: > On 2016/09/01 ...
4 years, 3 months ago (2016-09-01 20:31:46 UTC) #11
maxbogue
I updated the DTC class comment as well. https://codereview.chromium.org/2289143003/diff/60001/components/sync/driver/non_blocking_data_type_controller.cc File components/sync/driver/non_blocking_data_type_controller.cc (right): https://codereview.chromium.org/2289143003/diff/60001/components/sync/driver/non_blocking_data_type_controller.cc#newcode36 components/sync/driver/non_blocking_data_type_controller.cc:36: DCHECK(CalledOnValidThread()); ...
4 years, 3 months ago (2016-09-01 22:21:36 UTC) #16
maxbogue
Adding reviewers for the combined patch: stevet@: components/search_engines/* isherman@: components/autofill/* components/password_manager/* sky@: chrome/browser/* components/history/*
4 years, 3 months ago (2016-09-01 23:52:32 UTC) #21
Ilya Sherman
components/autofill/* and components/password_manager/* LGTM % a nit: https://codereview.chromium.org/2289143003/diff/100001/components/autofill/core/browser/autofill_wallet_data_type_controller.cc File components/autofill/core/browser/autofill_wallet_data_type_controller.cc (right): https://codereview.chromium.org/2289143003/diff/100001/components/autofill/core/browser/autofill_wallet_data_type_controller.cc#newcode31 components/autofill/core/browser/autofill_wallet_data_type_controller.cc:31: DCHECK(CalledOnValidThread()); What ...
4 years, 3 months ago (2016-09-02 00:19:06 UTC) #23
sky
LGTM https://codereview.chromium.org/2289143003/diff/100001/components/history/core/browser/history_delete_directives_data_type_controller.h File components/history/core/browser/history_delete_directives_data_type_controller.h (right): https://codereview.chromium.org/2289143003/diff/100001/components/history/core/browser/history_delete_directives_data_type_controller.h#newcode22 components/history/core/browser/history_delete_directives_data_type_controller.h:22: const base::Closure& dump_stack, I have to say that ...
4 years, 3 months ago (2016-09-02 14:06:29 UTC) #24
maxbogue
https://codereview.chromium.org/2289143003/diff/100001/components/autofill/core/browser/autofill_wallet_data_type_controller.cc File components/autofill/core/browser/autofill_wallet_data_type_controller.cc (right): https://codereview.chromium.org/2289143003/diff/100001/components/autofill/core/browser/autofill_wallet_data_type_controller.cc#newcode31 components/autofill/core/browser/autofill_wallet_data_type_controller.cc:31: DCHECK(CalledOnValidThread()); On 2016/09/02 00:19:05, Ilya Sherman wrote: > What ...
4 years, 3 months ago (2016-09-02 21:15:08 UTC) #27
maxbogue
Looks like stevet@ is no longer active... +pkasting for //components/search_engines.
4 years, 3 months ago (2016-09-02 21:34:32 UTC) #29
Peter Kasting
LGTM https://codereview.chromium.org/2289143003/diff/120001/components/search_engines/search_engine_data_type_controller_unittest.cc File components/search_engines/search_engine_data_type_controller_unittest.cc (right): https://codereview.chromium.org/2289143003/diff/120001/components/search_engines/search_engine_data_type_controller_unittest.cc#newcode43 components/search_engines/search_engine_data_type_controller_unittest.cc:43: new SearchEngineDataTypeController(base::Bind(&base::DoNothing), Nit: Can we just pass a ...
4 years, 3 months ago (2016-09-02 22:27:48 UTC) #30
skym
lgtm, only really nits, some where along this I became the #include police :( https://codereview.chromium.org/2289143003/diff/120001/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc ...
4 years, 3 months ago (2016-09-02 22:45:29 UTC) #33
maxbogue
https://codereview.chromium.org/2289143003/diff/120001/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc File chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc (left): https://codereview.chromium.org/2289143003/diff/120001/chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc#oldcode8 chrome/browser/supervised_user/supervised_user_sync_data_type_controller.cc:8: #include "content/public/browser/browser_thread.h" On 2016/09/02 22:45:28, skym wrote: > Now ...
4 years, 3 months ago (2016-09-03 00:14:52 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289143003/140001
4 years, 3 months ago (2016-09-03 00:15:43 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/218834) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-03 00:23:00 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289143003/140001
4 years, 3 months ago (2016-09-06 18:27:14 UTC) #41
commit-bot: I haz the power
Failed to apply patch for components/sync/api/model_type_service_unittest.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 3 months ago (2016-09-06 20:28:32 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289143003/160001
4 years, 3 months ago (2016-09-06 20:57:28 UTC) #46
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 3 months ago (2016-09-06 23:10:02 UTC) #48
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:12:03 UTC) #50
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/fd43b4b98dab6bdd565dad4a89e9baf341281f58
Cr-Commit-Position: refs/heads/master@{#416754}

Powered by Google App Engine
This is Rietveld 408576698