components/sync/driver/sync_service.h - Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/sync_service.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)

Patch Set: Rebase. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/sync_service.h

diff --git a/components/sync/driver/sync_service.h b/components/sync/driver/sync_service.h

index e74fedbf2ca458e312e8b07490ce2d3257d74c49..2f536bc46d377b14ae1a6f16ddd604527c46cd46 100644

--- a/components/sync/driver/sync_service.h

+++ b/components/sync/driver/sync_service.h

@@ -268,7 +268,7 @@ class SyncService : public DataTypeEncryptionHandler {

// enable or activate the synchronization of the data type (see

// ActivateDataType). Takes ownership of the pointer.

virtual void RegisterDataTypeController(

- DataTypeController* data_type_controller) = 0;

+ std::unique_ptr<DataTypeController> data_type_controller) = 0;

// Called to re-enable a type disabled by DisableDatatype(..). Note, this does

// not change the preferred state of a datatype, and is not persisted across