Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: components/sync_bookmarks/bookmark_model_associator.cc

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_bookmarks/bookmark_model_associator.cc
diff --git a/components/sync_bookmarks/bookmark_model_associator.cc b/components/sync_bookmarks/bookmark_model_associator.cc
index e49f91f596e9b538bc28fccb88cd5afdf33525d9..cea7ec4e91afc7ad063b9b275e1f10be3d007d71 100644
--- a/components/sync_bookmarks/bookmark_model_associator.cc
+++ b/components/sync_bookmarks/bookmark_model_associator.cc
@@ -4,7 +4,7 @@
#include "components/sync_bookmarks/bookmark_model_associator.h"
-#include <memory>
+#include <utility>
#include "base/bind.h"
#include "base/command_line.h"
@@ -310,12 +310,12 @@ BookmarkModelAssociator::BookmarkModelAssociator(
BookmarkModel* bookmark_model,
sync_driver::SyncClient* sync_client,
syncer::UserShare* user_share,
- syncer::DataTypeErrorHandler* unrecoverable_error_handler,
+ std::unique_ptr<syncer::DataTypeErrorHandler> unrecoverable_error_handler,
bool expect_mobile_bookmarks_folder)
: bookmark_model_(bookmark_model),
sync_client_(sync_client),
user_share_(user_share),
- unrecoverable_error_handler_(unrecoverable_error_handler),
+ unrecoverable_error_handler_(std::move(unrecoverable_error_handler)),
expect_mobile_bookmarks_folder_(expect_mobile_bookmarks_folder),
weak_factory_(this) {
DCHECK(bookmark_model_);
@@ -729,7 +729,7 @@ syncer::SyncError BookmarkModelAssociator::BuildAssociations(
for (int i = index; i < parent_node->child_count(); ++i) {
int64_t sync_child_id = BookmarkChangeProcessor::CreateSyncNode(
parent_node, bookmark_model_, i, trans, this,
- unrecoverable_error_handler_);
+ unrecoverable_error_handler_.get());
if (syncer::kInvalidId == sync_child_id) {
return unrecoverable_error_handler_->CreateAndUploadError(
FROM_HERE, "Failed to create sync node.", model_type());
@@ -791,7 +791,7 @@ int BookmarkModelAssociator::RemoveSyncNodeHierarchy(
syncer::SyncError error(FROM_HERE, syncer::SyncError::DATATYPE_ERROR,
"Could not lookup bookmark node for ID deletion.",
syncer::BOOKMARKS);
- unrecoverable_error_handler_->OnSingleDataTypeUnrecoverableError(error);
+ unrecoverable_error_handler_->OnUnrecoverableError(error);
return 0;
}
@@ -946,7 +946,7 @@ void BookmarkModelAssociator::PersistAssociations() {
syncer::SyncError::DATATYPE_ERROR,
"Could not lookup bookmark node for ID persistence.",
syncer::BOOKMARKS);
- unrecoverable_error_handler_->OnSingleDataTypeUnrecoverableError(error);
+ unrecoverable_error_handler_->OnUnrecoverableError(error);
return;
}
const BookmarkNode* node = GetChromeNodeFromSyncId(sync_id);
« no previous file with comments | « components/sync_bookmarks/bookmark_model_associator.h ('k') | components/sync_sessions/session_data_type_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698