Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: components/sync/driver/directory_data_type_controller.cc

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/directory_data_type_controller.cc
diff --git a/components/sync/driver/directory_data_type_controller.cc b/components/sync/driver/directory_data_type_controller.cc
index f8edd4d7c004d30f545b184caabb2d5687e15247..62a1720ab5ecb0ba115c70a1d80ecd9cfdfd4ac8 100644
--- a/components/sync/driver/directory_data_type_controller.cc
+++ b/components/sync/driver/directory_data_type_controller.cc
@@ -12,11 +12,10 @@
namespace sync_driver {
DirectoryDataTypeController::DirectoryDataTypeController(
- const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread,
- const base::Closure& error_callback,
+ syncer::ModelType type,
+ const base::Closure& dump_stack,
SyncClient* sync_client)
- : DataTypeController(ui_thread, error_callback),
- sync_client_(sync_client) {}
+ : DataTypeController(type, dump_stack), sync_client_(sync_client) {}
DirectoryDataTypeController::~DirectoryDataTypeController() {}
@@ -39,6 +38,7 @@ void DirectoryDataTypeController::RegisterWithBackend(
void DirectoryDataTypeController::ActivateDataType(
BackendDataTypeConfigurer* configurer) {
+ DCHECK(CalledOnValidThread());
// Tell the backend about the change processor for this type so it can
// begin routing changes to it.
configurer->ActivateDirectoryDataType(type(), model_safe_group(),
@@ -47,6 +47,7 @@ void DirectoryDataTypeController::ActivateDataType(
void DirectoryDataTypeController::DeactivateDataType(
BackendDataTypeConfigurer* configurer) {
+ DCHECK(CalledOnValidThread());
configurer->DeactivateDirectoryDataType(type());
}
« no previous file with comments | « components/sync/driver/directory_data_type_controller.h ('k') | components/sync/driver/fake_data_type_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698