[Sync] Convert DTCs to be not RefCounted and NonThreadSafe.

components/browser_sync/browser/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/browser_sync/browser/profile_sync_service.h"
 
 #include <stddef.h>
 
 #include <cstddef>
 #include <map>
@@ skipping 406 matching lines @@
     signin()->AddObserver(this);
 }
 
 void ProfileSyncService::UnregisterAuthNotifications() {
   if (signin())
     signin()->RemoveObserver(this);
   oauth2_token_service_->RemoveObserver(this);
 }
 
 void ProfileSyncService::RegisterDataTypeController(
-    sync_driver::DataTypeController* data_type_controller) {
+    std::unique_ptr<sync_driver::DataTypeController> data_type_controller) {
   DCHECK_EQ(data_type_controllers_.count(data_type_controller->type()), 0U);

[skym, 2016/09/02 22:45:28]

Ugh, count(...). What do you think of find?

[maxbogue, 2016/09/03 00:14:51]

Didn't compile for some reason... "error: no matching function for call to
'MakeCheckOpValueString'"

I'm just gonna leave it.

-  data_type_controllers_[data_type_controller->type()] = data_type_controller;
+  data_type_controllers_[data_type_controller->type()] =
+      std::move(data_type_controller);
 }
 
 bool ProfileSyncService::IsDataTypeControllerRunning(
     syncer::ModelType type) const {
   DataTypeController::TypeMap::const_iterator iter =
       data_type_controllers_.find(type);
   if (iter == data_type_controllers_.end()) {
     return false;
   }
   return iter->second->state() == DataTypeController::RUNNING;
@@ skipping 2090 matching lines @@
   if (--outstanding_setup_in_progress_handles_ != 0)
     return;
 
   DCHECK(startup_controller_->IsSetupInProgress());
   startup_controller_->SetSetupInProgress(false);
 
   if (IsBackendInitialized())
     ReconfigureDatatypeManager();
   NotifyObservers();
 }