Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: components/browser_sync/browser/profile_sync_components_factory_impl.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__ 5 #ifndef COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
6 #define COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__ 6 #define COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
7 7
8 #include <memory>
8 #include <string> 9 #include <string>
9 10
10 #include "base/command_line.h" 11 #include "base/command_line.h"
11 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
12 #include "base/macros.h" 13 #include "base/macros.h"
13 #include "base/memory/weak_ptr.h" 14 #include "base/memory/weak_ptr.h"
14 #include "components/sync/base/model_type.h" 15 #include "components/sync/base/model_type.h"
15 #include "components/sync/driver/sync_api_component_factory.h" 16 #include "components/sync/driver/sync_api_component_factory.h"
16 #include "components/version_info/version_info.h" 17 #include "components/version_info/version_info.h"
17 #include "url/gurl.h" 18 #include "url/gurl.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 CreateLocalDeviceInfoProvider() override; 79 CreateLocalDeviceInfoProvider() override;
79 std::unique_ptr<syncer::AttachmentService> CreateAttachmentService( 80 std::unique_ptr<syncer::AttachmentService> CreateAttachmentService(
80 std::unique_ptr<syncer::AttachmentStoreForSync> attachment_store, 81 std::unique_ptr<syncer::AttachmentStoreForSync> attachment_store,
81 const syncer::UserShare& user_share, 82 const syncer::UserShare& user_share,
82 const std::string& store_birthday, 83 const std::string& store_birthday,
83 syncer::ModelType model_type, 84 syncer::ModelType model_type,
84 syncer::AttachmentService::Delegate* delegate) override; 85 syncer::AttachmentService::Delegate* delegate) override;
85 sync_driver::SyncApiComponentFactory::SyncComponents 86 sync_driver::SyncApiComponentFactory::SyncComponents
86 CreateBookmarkSyncComponents( 87 CreateBookmarkSyncComponents(
87 sync_driver::SyncService* sync_service, 88 sync_driver::SyncService* sync_service,
88 syncer::DataTypeErrorHandler* error_handler) override; 89 std::unique_ptr<syncer::DataTypeErrorHandler> error_handler) override;
89 90
90 private: 91 private:
91 // Register data types which are enabled on both desktop and mobile. 92 // Register data types which are enabled on both desktop and mobile.
92 // |disabled_types| and |enabled_types| correspond only to those types 93 // |disabled_types| and |enabled_types| correspond only to those types
93 // being explicitly enabled/disabled by the command line. 94 // being explicitly enabled/disabled by the command line.
94 void RegisterCommonDataTypes(sync_driver::SyncService* sync_service, 95 void RegisterCommonDataTypes(sync_driver::SyncService* sync_service,
95 syncer::ModelTypeSet disabled_types, 96 syncer::ModelTypeSet disabled_types,
96 syncer::ModelTypeSet enabled_types); 97 syncer::ModelTypeSet enabled_types);
97 98
98 void DisableBrokenType(syncer::ModelType type, 99 void DisableBrokenType(syncer::ModelType type,
(...skipping 14 matching lines...) Expand all
113 net::URLRequestContextGetter* const url_request_context_getter_; 114 net::URLRequestContextGetter* const url_request_context_getter_;
114 const scoped_refptr<autofill::AutofillWebDataService> web_data_service_; 115 const scoped_refptr<autofill::AutofillWebDataService> web_data_service_;
115 const scoped_refptr<password_manager::PasswordStore> password_store_; 116 const scoped_refptr<password_manager::PasswordStore> password_store_;
116 117
117 base::WeakPtrFactory<ProfileSyncComponentsFactoryImpl> weak_factory_; 118 base::WeakPtrFactory<ProfileSyncComponentsFactoryImpl> weak_factory_;
118 119
119 DISALLOW_COPY_AND_ASSIGN(ProfileSyncComponentsFactoryImpl); 120 DISALLOW_COPY_AND_ASSIGN(ProfileSyncComponentsFactoryImpl);
120 }; 121 };
121 122
122 #endif // COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_ H__ 123 #endif // COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_ H__
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698