Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: components/sync/driver/generic_change_processor_factory.cc

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/generic_change_processor_factory.cc
diff --git a/components/sync/driver/generic_change_processor_factory.cc b/components/sync/driver/generic_change_processor_factory.cc
index 3980748520cc69f4649ed698b298c6299b16b3e8..7e2fb4adf4b487acee8e2ed2525febd649aecc4a 100644
--- a/components/sync/driver/generic_change_processor_factory.cc
+++ b/components/sync/driver/generic_change_processor_factory.cc
@@ -4,6 +4,8 @@
#include "components/sync/driver/generic_change_processor_factory.h"
+#include <utility>
+
#include "base/memory/ptr_util.h"
#include "components/sync/api/syncable_service.h"
#include "components/sync/driver/generic_change_processor.h"
@@ -18,14 +20,14 @@ std::unique_ptr<GenericChangeProcessor>
GenericChangeProcessorFactory::CreateGenericChangeProcessor(
syncer::ModelType type,
syncer::UserShare* user_share,
- syncer::DataTypeErrorHandler* error_handler,
+ std::unique_ptr<syncer::DataTypeErrorHandler> error_handler,
const base::WeakPtr<syncer::SyncableService>& local_service,
const base::WeakPtr<syncer::SyncMergeResult>& merge_result,
SyncClient* sync_client) {
DCHECK(user_share);
return base::MakeUnique<GenericChangeProcessor>(
- type, error_handler, local_service, merge_result, user_share, sync_client,
- local_service->GetAttachmentStoreForSync());
+ type, std::move(error_handler), local_service, merge_result, user_share,
+ sync_client, local_service->GetAttachmentStoreForSync());
}
} // namespace sync_driver
« no previous file with comments | « components/sync/driver/generic_change_processor_factory.h ('k') | components/sync/driver/generic_change_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698