Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2248)

Unified Diff: components/browser_sync/browser/profile_sync_service_autofill_unittest.cc

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/browser/profile_sync_service_autofill_unittest.cc
diff --git a/components/browser_sync/browser/profile_sync_service_autofill_unittest.cc b/components/browser_sync/browser/profile_sync_service_autofill_unittest.cc
index 0600fc8fbbeb5eaa65591b27e8cca037c9e83dea..0c9df358b837e0a6a2648b08686a8fe470de7cb3 100644
--- a/components/browser_sync/browser/profile_sync_service_autofill_unittest.cc
+++ b/components/browser_sync/browser/profile_sync_service_autofill_unittest.cc
@@ -612,17 +612,15 @@ class ProfileSyncServiceAutofillTest
EXPECT_CALL(autofill_table_, UpdateAutofillEntries(Not(empty))).Times(0);
}
- sync_driver::DataTypeController* CreateDataTypeController(
+ std::unique_ptr<sync_driver::DataTypeController> CreateDataTypeController(
syncer::ModelType type) {
DCHECK(type == AUTOFILL || type == AUTOFILL_PROFILE);
if (type == AUTOFILL) {
- return new AutofillDataTypeController(base::ThreadTaskRunnerHandle::Get(),
- data_type_thread()->task_runner(),
- base::Bind(&base::DoNothing),
- sync_client_, web_data_service_);
+ return base::MakeUnique<AutofillDataTypeController>(
+ data_type_thread()->task_runner(), base::Bind(&base::DoNothing),
+ sync_client_, web_data_service_);
} else {
- return new AutofillProfileDataTypeController(
- base::ThreadTaskRunnerHandle::Get(),
+ return base::MakeUnique<AutofillProfileDataTypeController>(
data_type_thread()->task_runner(), base::Bind(&base::DoNothing),
sync_client_, web_data_service_);
}

Powered by Google App Engine
This is Rietveld 408576698