Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: components/history/core/browser/history_delete_directives_data_type_controller.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_delete_directives_data_type_controller.h
diff --git a/components/history/core/browser/history_delete_directives_data_type_controller.h b/components/history/core/browser/history_delete_directives_data_type_controller.h
index e76115e0e07380f24d16b96ddc14cfa753d93dc1..66cd6ad86f2c7c46b48d7a722a646fb779aa64da 100644
--- a/components/history/core/browser/history_delete_directives_data_type_controller.h
+++ b/components/history/core/browser/history_delete_directives_data_type_controller.h
@@ -18,10 +18,11 @@ class HistoryDeleteDirectivesDataTypeController
: public sync_driver::UIDataTypeController,
public sync_driver::SyncServiceObserver {
public:
+ // |dump_stack| is called when an unrecoverable error occurs.
HistoryDeleteDirectivesDataTypeController(
- const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread,
- const base::Closure& error_callback,
+ const base::Closure& dump_stack,
sync_driver::SyncClient* sync_client);
+ ~HistoryDeleteDirectivesDataTypeController() override;
// UIDataTypeController override.
bool ReadyForStart() const override;
@@ -32,9 +33,6 @@ class HistoryDeleteDirectivesDataTypeController
void OnStateChanged() override;
private:
- // Refcounted.
- ~HistoryDeleteDirectivesDataTypeController() override;
-
// Triggers a SingleDataTypeUnrecoverable error and returns true if the
// type is no longer ready, else does nothing and returns false.
bool DisableTypeIfNecessary();

Powered by Google App Engine
This is Rietveld 408576698