Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: components/sync/driver/directory_data_type_controller.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/directory_data_type_controller.h
diff --git a/components/sync/driver/directory_data_type_controller.h b/components/sync/driver/directory_data_type_controller.h
index 16d1f94412ccb8aac78c5125049d749563954fad..76fa60f244105328cffc940eee97f9904fe85135 100644
--- a/components/sync/driver/directory_data_type_controller.h
+++ b/components/sync/driver/directory_data_type_controller.h
@@ -17,6 +17,8 @@ class ChangeProcessor;
// Base class for Directory based Data type controllers.
class DirectoryDataTypeController : public DataTypeController {
public:
+ ~DirectoryDataTypeController() override;
+
// DataTypeController implementation.
bool ShouldLoadModelBeforeConfigure() const override;
void GetAllNodes(const AllNodesCallback& callback) override;
@@ -47,6 +49,11 @@ class DirectoryDataTypeController : public DataTypeController {
syncer::syncable::Directory* directory);
protected:
+ // |dump_stack| is called when an unrecoverable error occurs.
+ DirectoryDataTypeController(syncer::ModelType type,
+ const base::Closure& dump_stack,
+ SyncClient* sync_client);
+
// The model safe group of this data type. This should reflect the
// thread that should be used to modify the data type's native
// model.
@@ -56,13 +63,6 @@ class DirectoryDataTypeController : public DataTypeController {
// Returns NULL if the ChangeProcessor isn't created or connected.
virtual ChangeProcessor* GetChangeProcessor() const = 0;
- DirectoryDataTypeController(
- const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread,
- const base::Closure& error_callback,
- SyncClient* sync_client);
-
- ~DirectoryDataTypeController() override;
-
SyncClient* const sync_client_;
};
« no previous file with comments | « components/sync/driver/data_type_manager_impl_unittest.cc ('k') | components/sync/driver/directory_data_type_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698