[Sync] Convert DTCs to be not RefCounted and NonThreadSafe.

components/sync/driver/generic_change_processor.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/driver/generic_change_processor.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
 #include <utility>
 
 #include "base/location.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "components/sync/api/data_type_error_handler.h"
 #include "components/sync/api/sync_change.h"
 #include "components/sync/api/sync_error.h"
 #include "components/sync/api/syncable_service.h"
 #include "components/sync/base/unrecoverable_error_handler.h"
 #include "components/sync/core/base_node.h"
 #include "components/sync/core/change_record.h"
-#include "components/sync/core/data_type_error_handler.h"
 #include "components/sync/core/read_node.h"
 #include "components/sync/core/read_transaction.h"
 #include "components/sync/core/write_node.h"
 #include "components/sync/core/write_transaction.h"
 #include "components/sync/driver/sync_api_component_factory.h"
 #include "components/sync/driver/sync_client.h"
 #include "components/sync/syncable/entry.h"  // TODO(tim): Bug 123674.
 
 namespace sync_driver {
 
@@ skipping 67 matching lines @@
           sync_id, read_node.GetEntitySpecifics(),
           read_node.GetModificationTime(), attachment_ids,
           attachment_service_proxy);
   }
 }
 
 }  // namespace
 
 GenericChangeProcessor::GenericChangeProcessor(
     syncer::ModelType type,
-    syncer::DataTypeErrorHandler* error_handler,
+    std::unique_ptr<syncer::DataTypeErrorHandler> error_handler,
     const base::WeakPtr<syncer::SyncableService>& local_service,
     const base::WeakPtr<syncer::SyncMergeResult>& merge_result,
     syncer::UserShare* user_share,
     SyncClient* sync_client,
     std::unique_ptr<syncer::AttachmentStoreForSync> attachment_store)
-    : ChangeProcessor(error_handler),
+    : ChangeProcessor(std::move(error_handler)),
       type_(type),
       local_service_(local_service),
       merge_result_(merge_result),
       share_handle_(user_share),
       weak_ptr_factory_(this) {
   DCHECK(CalledOnValidThread());
   DCHECK_NE(type_, syncer::UNSPECIFIED);
   if (attachment_store) {
     std::string store_birthday;
     {
@@ skipping 51 matching lines @@
               ? syncer::SyncChange::ACTION_ADD
               : syncer::SyncChange::ACTION_UPDATE;
       // Need to load specifics from node.
       syncer::ReadNode read_node(trans);
       if (read_node.InitByIdLookup(it->id) != syncer::BaseNode::INIT_OK) {
         syncer::SyncError error(
             FROM_HERE, syncer::SyncError::DATATYPE_ERROR,
             "Failed to look up data for received change with id " +
                 base::Int64ToString(it->id),
             syncer::GetModelTypeFromSpecifics(it->specifics));
-        error_handler()->OnSingleDataTypeUnrecoverableError(error);
+        error_handler()->OnUnrecoverableError(error);
         return;
       }
       syncer_changes_.push_back(syncer::SyncChange(
           FROM_HERE, action,
           BuildRemoteSyncData(it->id, read_node, attachment_service_proxy_)));
     }
   }
 }
 
 void GenericChangeProcessor::CommitChangesFromSyncModel() {
   DCHECK(CalledOnValidThread());
   if (syncer_changes_.empty())
     return;
   if (!local_service_.get()) {
     syncer::ModelType type = syncer_changes_[0].sync_data().GetDataType();
     syncer::SyncError error(FROM_HERE, syncer::SyncError::DATATYPE_ERROR,
                             "Local service destroyed.", type);
-    error_handler()->OnSingleDataTypeUnrecoverableError(error);
+    error_handler()->OnUnrecoverableError(error);
     return;
   }
   syncer::SyncError error =
       local_service_->ProcessSyncChanges(FROM_HERE, syncer_changes_);
   syncer_changes_.clear();
   if (error.IsSet())
-    error_handler()->OnSingleDataTypeUnrecoverableError(error);
+    error_handler()->OnUnrecoverableError(error);
 }
 
 syncer::SyncDataList GenericChangeProcessor::GetAllSyncData(
     syncer::ModelType type) const {
   DCHECK_EQ(type_, type);
   // This is slow / memory intensive.  Should be used sparingly by datatypes.
   syncer::SyncDataList data;
   GetAllSyncDataReturnError(&data);
   return data;
 }
@@ skipping 80 matching lines @@
   if (root.InitTypeRoot(type_) != syncer::BaseNode::INIT_OK)
     return 0;
 
   // Subtract one to account for type's root node.
   return root.GetTotalNodeCount() - 1;
 }
 
 namespace {
 
 // WARNING: this code is sensitive to compiler optimizations. Be careful
-// modifying any code around an OnSingleDataTypeUnrecoverableError call, else
-// the compiler attempts to merge it with other calls, losing useful information
-// in breakpad uploads.
+// modifying any code around an OnUnrecoverableError call, else the compiler
+// attempts to merge it with other calls, losing useful information in
+// breakpad uploads.
 syncer::SyncError LogLookupFailure(
     syncer::BaseNode::InitByLookupResult lookup_result,
     const tracked_objects::Location& from_here,
     const std::string& error_prefix,
     syncer::ModelType type,
     syncer::DataTypeErrorHandler* error_handler) {
   switch (lookup_result) {
     case syncer::BaseNode::INIT_FAILED_ENTRY_NOT_GOOD: {
       syncer::SyncError error;
       error.Reset(
           from_here,
           error_prefix + "could not find entry matching the lookup criteria.",
           type);
-      error_handler->OnSingleDataTypeUnrecoverableError(error);
+      error_handler->OnUnrecoverableError(error);
       LOG(ERROR) << "Delete: Bad entry.";
       return error;
     }
     case syncer::BaseNode::INIT_FAILED_ENTRY_IS_DEL: {
       syncer::SyncError error;
       error.Reset(from_here, error_prefix + "entry is already deleted.", type);
-      error_handler->OnSingleDataTypeUnrecoverableError(error);
+      error_handler->OnUnrecoverableError(error);
       LOG(ERROR) << "Delete: Deleted entry.";
       return error;
     }
     case syncer::BaseNode::INIT_FAILED_DECRYPT_IF_NECESSARY: {
       syncer::SyncError error;
       error.Reset(from_here, error_prefix + "unable to decrypt", type);
-      error_handler->OnSingleDataTypeUnrecoverableError(error);
+      error_handler->OnUnrecoverableError(error);
       LOG(ERROR) << "Delete: Undecryptable entry.";
       return error;
     }
     case syncer::BaseNode::INIT_FAILED_PRECONDITION: {
       syncer::SyncError error;
       error.Reset(from_here,
                   error_prefix + "a precondition was not met for calling init.",
                   type);
-      error_handler->OnSingleDataTypeUnrecoverableError(error);
+      error_handler->OnUnrecoverableError(error);
       LOG(ERROR) << "Delete: Failed precondition.";
       return error;
     }
     default: {
       syncer::SyncError error;
       // Should have listed all the possible error cases above.
       error.Reset(from_here, error_prefix + "unknown error", type);
-      error_handler->OnSingleDataTypeUnrecoverableError(error);
+      error_handler->OnUnrecoverableError(error);
       LOG(ERROR) << "Delete: Unknown error.";
       return error;
     }
   }
 }
 
 syncer::SyncError AttemptDelete(const syncer::SyncChange& change,
                                 syncer::ModelType type,
                                 const std::string& type_str,
                                 syncer::WriteNode* node,
                                 syncer::DataTypeErrorHandler* error_handler) {
   DCHECK_EQ(change.change_type(), syncer::SyncChange::ACTION_DELETE);
   if (change.sync_data().IsLocal()) {
     const std::string& tag = syncer::SyncDataLocal(change.sync_data()).GetTag();
     if (tag.empty()) {
       syncer::SyncError error(FROM_HERE, syncer::SyncError::DATATYPE_ERROR,
                               "Failed to delete " + type_str +
                                   " node. Local data, empty tag. " +
                                   change.location().ToString(),
                               type);
-      error_handler->OnSingleDataTypeUnrecoverableError(error);
+      error_handler->OnUnrecoverableError(error);
       NOTREACHED();
       return error;
     }
 
     syncer::BaseNode::InitByLookupResult result =
         node->InitByClientTagLookup(change.sync_data().GetDataType(), tag);
     if (result != syncer::BaseNode::INIT_OK) {
       return LogLookupFailure(result, FROM_HERE,
                               "Failed to delete " + type_str +
                                   " node. Local data. " +
@@ skipping 64 matching lines @@
           change, type_str, trans, &sync_node, &new_attachments);
       if (error.IsSet()) {
         return error;
       }
     } else {
       syncer::SyncError error(
           FROM_HERE, syncer::SyncError::DATATYPE_ERROR,
           "Received unset SyncChange in the change processor, " +
               change.location().ToString(),
           type_);
-      error_handler()->OnSingleDataTypeUnrecoverableError(error);
+      error_handler()->OnUnrecoverableError(error);
       NOTREACHED();
       LOG(ERROR) << "Unset sync change.";
       return error;
     }
   }
 
   if (!new_attachments.empty()) {
     // If datatype uses attachments it should have supplied attachment store
     // which would initialize attachment_service_. Fail if it isn't so.
     if (!attachment_service_.get()) {
       syncer::SyncError error(
           FROM_HERE, syncer::SyncError::DATATYPE_ERROR,
           "Datatype performs attachment operation without initializing "
           "attachment store",
           type_);
-      error_handler()->OnSingleDataTypeUnrecoverableError(error);
+      error_handler()->OnUnrecoverableError(error);
       NOTREACHED();
       return error;
     }
     syncer::AttachmentIdList ids_to_upload;
     ids_to_upload.reserve(new_attachments.size());
     std::copy(new_attachments.begin(), new_attachments.end(),
               std::back_inserter(ids_to_upload));
     attachment_service_->UploadAttachments(ids_to_upload);
   }
 
   return syncer::SyncError();
 }
 
 // WARNING: this code is sensitive to compiler optimizations. Be careful
-// modifying any code around an OnSingleDataTypeUnrecoverableError call, else
-// the compiler attempts to merge it with other calls, losing useful information
-// in breakpad uploads.
+// modifying any code around an OnUnrecoverableError call, else the compiler
+// attempts to merge it with other calls, losing useful information in
+// breakpad uploads.
 syncer::SyncError GenericChangeProcessor::HandleActionAdd(
     const syncer::SyncChange& change,
     const std::string& type_str,
     const syncer::WriteTransaction& trans,
     syncer::WriteNode* sync_node,
     syncer::AttachmentIdSet* new_attachments) {
   // TODO(sync): Handle other types of creation (custom parents, folders,
   // etc.).
   const syncer::SyncDataLocal sync_data_local(change.sync_data());
   syncer::WriteNode::InitUniqueByCreationResult result =
       sync_node->InitUniqueByCreation(sync_data_local.GetDataType(),
                                       sync_data_local.GetTag());
   if (result != syncer::WriteNode::INIT_SUCCESS) {
     std::string error_prefix = "Failed to create " + type_str + " node: " +
                                change.location().ToString() + ", ";
     switch (result) {
       case syncer::WriteNode::INIT_FAILED_EMPTY_TAG: {
         syncer::SyncError error;
         error.Reset(FROM_HERE, error_prefix + "empty tag", type_);
-        error_handler()->OnSingleDataTypeUnrecoverableError(error);
+        error_handler()->OnUnrecoverableError(error);
         LOG(ERROR) << "Create: Empty tag.";
         return error;
       }
       case syncer::WriteNode::INIT_FAILED_COULD_NOT_CREATE_ENTRY: {
         syncer::SyncError error;
         error.Reset(FROM_HERE, error_prefix + "failed to create entry", type_);
-        error_handler()->OnSingleDataTypeUnrecoverableError(error);
+        error_handler()->OnUnrecoverableError(error);
         LOG(ERROR) << "Create: Could not create entry.";
         return error;
       }
       case syncer::WriteNode::INIT_FAILED_SET_PREDECESSOR: {
         syncer::SyncError error;
         error.Reset(FROM_HERE, error_prefix + "failed to set predecessor",
                     type_);
-        error_handler()->OnSingleDataTypeUnrecoverableError(error);
+        error_handler()->OnUnrecoverableError(error);
         LOG(ERROR) << "Create: Bad predecessor.";
         return error;
       }
       case syncer::WriteNode::INIT_FAILED_DECRYPT_EXISTING_ENTRY: {
         syncer::SyncError error;
         error.Reset(FROM_HERE, error_prefix + "failed to decrypt", type_);
-        error_handler()->OnSingleDataTypeUnrecoverableError(error);
+        error_handler()->OnUnrecoverableError(error);
         LOG(ERROR) << "Create: Failed to decrypt.";
         return error;
       }
       default: {
         syncer::SyncError error;
         error.Reset(FROM_HERE, error_prefix + "unknown error", type_);
-        error_handler()->OnSingleDataTypeUnrecoverableError(error);
+        error_handler()->OnUnrecoverableError(error);
         LOG(ERROR) << "Create: Unknown error.";
         return error;
       }
     }
   }
   sync_node->SetTitle(change.sync_data().GetTitle());
   SetNodeSpecifics(sync_data_local.GetSpecifics(), sync_node);
 
   syncer::AttachmentIdList attachment_ids = sync_data_local.GetAttachmentIds();
   SetAttachmentMetadata(attachment_ids, sync_node);
 
   // Return any newly added attachments.
   new_attachments->insert(attachment_ids.begin(), attachment_ids.end());
   if (merge_result_.get()) {
     merge_result_->set_num_items_added(merge_result_->num_items_added() + 1);
   }
   return syncer::SyncError();
 }
 // WARNING: this code is sensitive to compiler optimizations. Be careful
-// modifying any code around an OnSingleDataTypeUnrecoverableError call, else
-// the compiler attempts to merge it with other calls, losing useful information
-// in breakpad uploads.
+// modifying any code around an OnUnrecoverableError call, else the compiler
+// attempts to merge it with other calls, losing useful information in
+// breakpad uploads.
 syncer::SyncError GenericChangeProcessor::HandleActionUpdate(
     const syncer::SyncChange& change,
     const std::string& type_str,
     const syncer::WriteTransaction& trans,
     syncer::WriteNode* sync_node,
     syncer::AttachmentIdSet* new_attachments) {
   const syncer::SyncDataLocal sync_data_local(change.sync_data());
   syncer::BaseNode::InitByLookupResult result =
       sync_node->InitByClientTagLookup(sync_data_local.GetDataType(),
                                        sync_data_local.GetTag());
   if (result != syncer::BaseNode::INIT_OK) {
     std::string error_prefix = "Failed to load " + type_str + " node. " +
                                change.location().ToString() + ", ";
     if (result == syncer::BaseNode::INIT_FAILED_PRECONDITION) {
       syncer::SyncError error;
       error.Reset(FROM_HERE, error_prefix + "empty tag", type_);
-      error_handler()->OnSingleDataTypeUnrecoverableError(error);
+      error_handler()->OnUnrecoverableError(error);
       LOG(ERROR) << "Update: Empty tag.";
       return error;
     } else if (result == syncer::BaseNode::INIT_FAILED_ENTRY_NOT_GOOD) {
       syncer::SyncError error;
       error.Reset(FROM_HERE, error_prefix + "bad entry", type_);
-      error_handler()->OnSingleDataTypeUnrecoverableError(error);
+      error_handler()->OnUnrecoverableError(error);
       LOG(ERROR) << "Update: bad entry.";
       return error;
     } else if (result == syncer::BaseNode::INIT_FAILED_ENTRY_IS_DEL) {
       syncer::SyncError error;
       error.Reset(FROM_HERE, error_prefix + "deleted entry", type_);
-      error_handler()->OnSingleDataTypeUnrecoverableError(error);
+      error_handler()->OnUnrecoverableError(error);
       LOG(ERROR) << "Update: deleted entry.";
       return error;
     } else if (result == syncer::BaseNode::INIT_FAILED_DECRYPT_IF_NECESSARY) {
       syncer::SyncError error;
       error.Reset(FROM_HERE, error_prefix + "failed to decrypt", type_);
-      error_handler()->OnSingleDataTypeUnrecoverableError(error);
+      error_handler()->OnUnrecoverableError(error);
       LOG(ERROR) << "Update: Failed to decrypt.";
       return error;
     } else {
       NOTREACHED();
       syncer::SyncError error;
       error.Reset(FROM_HERE, error_prefix + "unknown error", type_);
-      error_handler()->OnSingleDataTypeUnrecoverableError(error);
+      error_handler()->OnUnrecoverableError(error);
       LOG(ERROR) << "Update: Unknown error.";
       return error;
     }
   }
 
   sync_node->SetTitle(change.sync_data().GetTitle());
   SetNodeSpecifics(sync_data_local.GetSpecifics(), sync_node);
   syncer::AttachmentIdList attachment_ids = sync_data_local.GetAttachmentIds();
   SetAttachmentMetadata(attachment_ids, sync_node);
 
@@ skipping 58 matching lines @@
   }
 }
 
 std::unique_ptr<syncer::AttachmentService>
 GenericChangeProcessor::GetAttachmentService() const {
   return std::unique_ptr<syncer::AttachmentService>(
       new syncer::AttachmentServiceProxy(attachment_service_proxy_));
 }
 
 }  // namespace sync_driver