Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2695)

Unified Diff: components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h
diff --git a/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h b/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h
index 2186bb29bab262ee4c8675d8ec6c34c69543a5bd..f02c1eaec21d7bc4fcf206c61afaefd70451e799 100644
--- a/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h
+++ b/components/autofill/core/browser/webdata/autofill_profile_data_type_controller.h
@@ -24,23 +24,21 @@ class AutofillProfileDataTypeController
: public sync_driver::NonUIDataTypeController,
public autofill::PersonalDataManagerObserver {
public:
+ // |dump_stack| is called when an unrecoverable error occurs.
AutofillProfileDataTypeController(
- const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread,
const scoped_refptr<base::SingleThreadTaskRunner>& db_thread,
- const base::Closure& error_callback,
+ const base::Closure& dump_stack,
sync_driver::SyncClient* sync_client,
const scoped_refptr<autofill::AutofillWebDataService>& web_data_service);
+ ~AutofillProfileDataTypeController() override;
// NonUIDataTypeController:
- syncer::ModelType type() const override;
syncer::ModelSafeGroup model_safe_group() const override;
// PersonalDataManagerObserver:
void OnPersonalDataChanged() override;
protected:
- ~AutofillProfileDataTypeController() override;
-
// NonUIDataTypeController:
bool PostTaskOnBackendThread(const tracked_objects::Location& from_here,
const base::Closure& task) override;
@@ -51,9 +49,6 @@ class AutofillProfileDataTypeController
// Callback to notify that WebDatabase has loaded.
void WebDatabaseLoaded();
- // A reference to the UI thread's task runner.
- const scoped_refptr<base::SingleThreadTaskRunner> ui_thread_;
-
// A reference to the DB thread's task runner.
const scoped_refptr<base::SingleThreadTaskRunner> db_thread_;

Powered by Google App Engine
This is Rietveld 408576698