Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: components/sync/driver/fake_data_type_controller.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/fake_data_type_controller.h
diff --git a/components/sync/driver/fake_data_type_controller.h b/components/sync/driver/fake_data_type_controller.h
index e05d430ec5241348c948627e605a3673930a705a..7fbf87df2135eb176b857878fe02ed03006f29ed 100644
--- a/components/sync/driver/fake_data_type_controller.h
+++ b/components/sync/driver/fake_data_type_controller.h
@@ -5,6 +5,7 @@
#ifndef COMPONENTS_SYNC_DRIVER_FAKE_DATA_TYPE_CONTROLLER_H__
#define COMPONENTS_SYNC_DRIVER_FAKE_DATA_TYPE_CONTROLLER_H__
+#include <memory>
#include <string>
#include "components/sync/driver/data_type_manager.h"
@@ -24,6 +25,7 @@ namespace sync_driver {
class FakeDataTypeController : public DirectoryDataTypeController {
public:
explicit FakeDataTypeController(syncer::ModelType type);
+ ~FakeDataTypeController() override;
// DirectoryDataTypeController implementation.
bool ShouldLoadModelBeforeConfigure() const override;
@@ -31,14 +33,12 @@ class FakeDataTypeController : public DirectoryDataTypeController {
void RegisterWithBackend(BackendDataTypeConfigurer* configurer) override;
void StartAssociating(const StartCallback& start_callback) override;
void Stop() override;
- syncer::ModelType type() const override;
std::string name() const override;
syncer::ModelSafeGroup model_safe_group() const override;
ChangeProcessor* GetChangeProcessor() const override;
State state() const override;
- void OnSingleDataTypeUnrecoverableError(
- const syncer::SyncError& error) override;
bool ReadyForStart() const override;
+ std::unique_ptr<syncer::DataTypeErrorHandler> CreateErrorHandler() override;
void FinishStart(ConfigureResult result);
@@ -56,13 +56,9 @@ class FakeDataTypeController : public DirectoryDataTypeController {
return register_with_backend_call_count_;
}
- protected:
- ~FakeDataTypeController() override;
-
private:
DataTypeController::State state_;
bool model_load_delayed_;
- syncer::ModelType type_;
StartCallback last_start_callback_;
ModelLoadCallback model_load_callback_;
syncer::SyncError load_error_;
« no previous file with comments | « components/sync/driver/directory_data_type_controller.cc ('k') | components/sync/driver/fake_data_type_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698