Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: components/sync_sessions/session_data_type_controller.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_sessions/session_data_type_controller.h
diff --git a/components/sync_sessions/session_data_type_controller.h b/components/sync_sessions/session_data_type_controller.h
index beb0e11c15c124acc58013b5378b0fe9ed629ce1..06cebdfa339c15d2564cfbb00320aa081272ee45 100644
--- a/components/sync_sessions/session_data_type_controller.h
+++ b/components/sync_sessions/session_data_type_controller.h
@@ -19,12 +19,12 @@ namespace browser_sync {
// device info to become available.
class SessionDataTypeController : public sync_driver::UIDataTypeController {
public:
- SessionDataTypeController(
- const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread,
- const base::Closure& error_callback,
- sync_driver::SyncClient* sync_client,
- sync_driver::LocalDeviceInfoProvider* local_device,
- const char* history_disabled_pref_name);
+ // |dump_stack| is called when an unrecoverable error occurs.
+ SessionDataTypeController(const base::Closure& dump_stack,
+ sync_driver::SyncClient* sync_client,
+ sync_driver::LocalDeviceInfoProvider* local_device,
+ const char* history_disabled_pref_name);
+ ~SessionDataTypeController() override;
// UIDataTypeController interface.
bool StartModels() override;
@@ -34,9 +34,6 @@ class SessionDataTypeController : public sync_driver::UIDataTypeController {
// Called when asynchronous session restore has completed.
void OnSessionRestoreComplete();
- protected:
- ~SessionDataTypeController() override;
-
private:
bool IsWaiting();
void MaybeCompleteLoading();
« no previous file with comments | « components/sync_bookmarks/bookmark_model_associator.cc ('k') | components/sync_sessions/session_data_type_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698