Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: components/sync/driver/sync_api_component_factory.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/sync_api_component_factory.h
diff --git a/components/sync/driver/sync_api_component_factory.h b/components/sync/driver/sync_api_component_factory.h
index 530fc8cfc01d349e1b688ee1b35919e5ae4aaa8c..3d59ad76a614b142531c1f68f2835467b887d06e 100644
--- a/components/sync/driver/sync_api_component_factory.h
+++ b/components/sync/driver/sync_api_component_factory.h
@@ -9,6 +9,7 @@
#include <string>
#include "base/memory/weak_ptr.h"
+#include "components/sync/api/data_type_error_handler.h"
#include "components/sync/api/syncable_service.h"
#include "components/sync/base/model_type.h"
#include "components/sync/core/attachments/attachment_service.h"
@@ -32,7 +33,6 @@ class InvalidationService;
namespace syncer {
class DataTypeDebugInfoListener;
-class DataTypeErrorHandler;
class SyncableService;
struct UserShare;
@@ -117,7 +117,7 @@ class SyncApiComponentFactory {
// Legacy datatypes that need to be converted to the SyncableService API.
virtual SyncComponents CreateBookmarkSyncComponents(
sync_driver::SyncService* sync_service,
- syncer::DataTypeErrorHandler* error_handler) = 0;
+ std::unique_ptr<syncer::DataTypeErrorHandler> error_handler) = 0;
// Creates attachment service.
// Note: Should only be called from the model type thread.
« no previous file with comments | « components/sync/driver/shared_change_processor_unittest.cc ('k') | components/sync/driver/sync_api_component_factory_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698