Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: components/sync_bookmarks/bookmark_model_associator.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_bookmarks/bookmark_model_associator.h
diff --git a/components/sync_bookmarks/bookmark_model_associator.h b/components/sync_bookmarks/bookmark_model_associator.h
index 37c82764a07ea5e2022638d5b611b21e671c58da..d5201d375c384b916b9e8d3e7af0bee346a25021 100644
--- a/components/sync_bookmarks/bookmark_model_associator.h
+++ b/components/sync_bookmarks/bookmark_model_associator.h
@@ -9,6 +9,7 @@
#include <stdint.h>
#include <map>
+#include <memory>
#include <set>
#include <stack>
#include <string>
@@ -21,8 +22,8 @@
#include "base/memory/weak_ptr.h"
#include "base/strings/string16.h"
#include "base/threading/thread_checker.h"
+#include "components/sync/api/data_type_error_handler.h"
#include "components/sync/base/unrecoverable_error_handler.h"
-#include "components/sync/core/data_type_error_handler.h"
#include "components/sync/driver/model_associator.h"
class GURL;
@@ -61,7 +62,7 @@ class BookmarkModelAssociator
bookmarks::BookmarkModel* bookmark_model,
sync_driver::SyncClient* sync_client,
syncer::UserShare* user_share,
- syncer::DataTypeErrorHandler* unrecoverable_error_handler,
+ std::unique_ptr<syncer::DataTypeErrorHandler> unrecoverable_error_handler,
bool expect_mobile_bookmarks_folder);
~BookmarkModelAssociator() override;
@@ -294,7 +295,7 @@ class BookmarkModelAssociator
bookmarks::BookmarkModel* bookmark_model_;
sync_driver::SyncClient* sync_client_;
syncer::UserShare* user_share_;
- syncer::DataTypeErrorHandler* unrecoverable_error_handler_;
+ std::unique_ptr<syncer::DataTypeErrorHandler> unrecoverable_error_handler_;
const bool expect_mobile_bookmarks_folder_;
BookmarkIdToSyncIdMap id_map_;
SyncIdToBookmarkNodeMap id_map_inverse_;

Powered by Google App Engine
This is Rietveld 408576698