Remove now-unnecessary .obj() in Java method calls.

Remove now-unnecessary .obj() in Java method calls.

Java methods can now be passed JavaRef parameters directly; remove calls
to .obj() that were being used to convert JavaRef to bare jobject, in
preparation for requiring JavaRef to be used.

This CL only fixes cases that can be fixed by removing the precise
string ".obj()" from a function call and does not introduce any other
changes (though it was run through git cl format to rewrap lines
afterward). This is to enable rubberstamp reviews.

There are a much smaller number of nontrivial changes required to
completely eliminate use of bare jobject as Java method parameters,
which will come in followup CLs for proper review.

BUG=506850
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/948f366645b6e37e2a43bac70c07a8d5c7e592eb
Cr-Commit-Position: refs/heads/master@{#412237}

[Torne, 2016-08-11 17:54:02]

Description was changed from

==========
Remove now-unnecessary .obj() in Java method calls.

Java methods can now be passed JavaRef parameters directly; remove calls
to .obj() that were being used to convert JavaRef to bare jobject, in
preparation for requiring JavaRef to be used.

This CL only fixes cases that can be fixed by removing the precise
string ".obj()" from a function call and does not introduce any other
changes (though it was run through git cl format to rewrap lines
afterward). This is to enable rubberstamp reviews.

There are a much smaller number of nontrivial changes required to
completely eliminate use of bare jobject as Java method parameters,
which will come in followup CLs for proper review.

BUG=506850
==========

to

==========
Remove now-unnecessary .obj() in Java method calls.

Java methods can now be passed JavaRef parameters directly; remove calls
to .obj() that were being used to convert JavaRef to bare jobject, in
preparation for requiring JavaRef to be used.

This CL only fixes cases that can be fixed by removing the precise
string ".obj()" from a function call and does not introduce any other
changes (though it was run through git cl format to rewrap lines
afterward). This is to enable rubberstamp reviews.

There are a much smaller number of nontrivial changes required to
completely eliminate use of bare jobject as Java method parameters,
which will come in followup CLs for proper review.

BUG=506850
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Torne, 2016-08-11 17:54:31]

The CQ bit was checked by torne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 17:54:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 19:04:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 19:04:59]

Dry run: This issue passed the CQ dry run.

[Torne, 2016-08-12 08:39:53]

torne@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Torne, 2016-08-12 08:39:55]

Ross, does this seem sane? The combination of converting GetApplicationContext
and this CL fixes >90% of java calls to pass JavaRef, leaving just a small
number of cases I'll need to go through manually and make non-automated fixes
to.

Not expecting you to read the entire diff :) I verified that the
pre-git-cl-format version did literally nothing other than remove ".obj()" (with
git diff --word-diff=porcelain - a conveniently machine-parseable format), so it
seems like any problem that introduced should have been a compile failure (and
there were some cases where that happened, but I just backed those specific
changes out and will look at them manually later).

[rmcilroy, 2016-08-12 09:23:53]

Yup, seems sane to me. LGTM, thanks.

[Torne, 2016-08-12 13:05:20]

torne@chromium.org changed reviewers:
+ ben@chromium.org

[Torne, 2016-08-12 13:05:21]

Hi Ben; this should be the last massive machine-generated refactoring patch for
JNI (for a while, at least) - can I get a top-level owner approval for this? :)

[Ben Goodger (Google), 2016-08-12 14:11:27]

rs lgtm

[Torne, 2016-08-16 13:44:46]

The CQ bit was checked by torne@chromium.org

[Torne, 2016-08-16 13:44:47]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2237943002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-16 13:44:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 13:48:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 13:48:26]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Torne, 2016-08-16 13:54:25]

Oh wow, the patch got out of date in the 30 minutes since I uploaded it :(

try #2...

[Torne, 2016-08-16 13:58:24]

The CQ bit was checked by torne@chromium.org

[Torne, 2016-08-16 13:58:26]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2237943002/#ps40001
(title: "Rebase *again* :(")

[commit-bot: I haz the power, 2016-08-16 13:58:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 15:11:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-16 15:12:36]

Description was changed from

==========
Remove now-unnecessary .obj() in Java method calls.

Java methods can now be passed JavaRef parameters directly; remove calls
to .obj() that were being used to convert JavaRef to bare jobject, in
preparation for requiring JavaRef to be used.

This CL only fixes cases that can be fixed by removing the precise
string ".obj()" from a function call and does not introduce any other
changes (though it was run through git cl format to rewrap lines
afterward). This is to enable rubberstamp reviews.

There are a much smaller number of nontrivial changes required to
completely eliminate use of bare jobject as Java method parameters,
which will come in followup CLs for proper review.

BUG=506850
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove now-unnecessary .obj() in Java method calls.

Java methods can now be passed JavaRef parameters directly; remove calls
to .obj() that were being used to convert JavaRef to bare jobject, in
preparation for requiring JavaRef to be used.

This CL only fixes cases that can be fixed by removing the precise
string ".obj()" from a function call and does not introduce any other
changes (though it was run through git cl format to rewrap lines
afterward). This is to enable rubberstamp reviews.

There are a much smaller number of nontrivial changes required to
completely eliminate use of bare jobject as Java method parameters,
which will come in followup CLs for proper review.

BUG=506850
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/948f366645b6e37e2a43bac70c07a8d5c7e592eb
Cr-Commit-Position: refs/heads/master@{#412237}
==========

[commit-bot: I haz the power, 2016-08-16 15:12:40]

Patchset 3 (id:??) landed as
https://crrev.com/948f366645b6e37e2a43bac70c07a8d5c7e592eb
Cr-Commit-Position: refs/heads/master@{#412237}