Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: chrome/browser/android/cookies/cookies_fetcher.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/cookies/cookies_fetcher.cc
diff --git a/chrome/browser/android/cookies/cookies_fetcher.cc b/chrome/browser/android/cookies/cookies_fetcher.cc
index 4fdf13f1a6f3cc7ce7014b324905f77dd6641753..1711d7901beb9db11faec23da22f3ad06a171f88 100644
--- a/chrome/browser/android/cookies/cookies_fetcher.cc
+++ b/chrome/browser/android/cookies/cookies_fetcher.cc
@@ -74,8 +74,7 @@ void CookiesFetcher::OnCookiesFetchFinished(const net::CookieList& cookies) {
JNIEnv* env = base::android::AttachCurrentThread();
ScopedJavaLocalRef<jobjectArray> joa =
- Java_CookiesFetcher_createCookiesArray(
- env, jobject_.obj(), cookies.size());
+ Java_CookiesFetcher_createCookiesArray(env, jobject_, cookies.size());
int index = 0;
for (net::CookieList::const_iterator i = cookies.begin();
@@ -84,18 +83,17 @@ void CookiesFetcher::OnCookiesFetchFinished(const net::CookieList& cookies) {
if (domain.length() > 1 && domain[0] == '.')
domain = domain.substr(1);
ScopedJavaLocalRef<jobject> java_cookie = Java_CookiesFetcher_createCookie(
- env, jobject_.obj(),
- base::android::ConvertUTF8ToJavaString(env, i->Name()).obj(),
- base::android::ConvertUTF8ToJavaString(env, i->Value()).obj(),
- base::android::ConvertUTF8ToJavaString(env, i->Domain()).obj(),
- base::android::ConvertUTF8ToJavaString(env, i->Path()).obj(),
+ env, jobject_, base::android::ConvertUTF8ToJavaString(env, i->Name()),
+ base::android::ConvertUTF8ToJavaString(env, i->Value()),
+ base::android::ConvertUTF8ToJavaString(env, i->Domain()),
+ base::android::ConvertUTF8ToJavaString(env, i->Path()),
i->CreationDate().ToInternalValue(), i->ExpiryDate().ToInternalValue(),
i->LastAccessDate().ToInternalValue(), i->IsSecure(), i->IsHttpOnly(),
static_cast<int>(i->SameSite()), i->Priority());
env->SetObjectArrayElement(joa.obj(), index++, java_cookie.obj());
}
- Java_CookiesFetcher_onCookieFetchFinished(env, jobject_.obj(), joa.obj());
+ Java_CookiesFetcher_onCookieFetchFinished(env, jobject_, joa);
// Give up the reference.
jobject_.Reset();

Powered by Google App Engine
This is Rietveld 408576698