chrome/browser/ui/android/infobars/infobar_container_android.cc - Issue 2237943002: Remove now-unnecessary .obj() in Java method calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/infobar_container_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context

Patch Set: Rebase *again* :( Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/infobar_android.cc ('k') | chrome/browser/ui/android/infobars/save_password_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/infobar_container_android.cc

diff --git a/chrome/browser/ui/android/infobars/infobar_container_android.cc b/chrome/browser/ui/android/infobars/infobar_container_android.cc

index 9d708e61445a1ff60436f9e798bfadf9dc912c15..1c6836f3b9be0e74ec0cd7926ac51f8b4649b184 100644

--- a/chrome/browser/ui/android/infobars/infobar_container_android.cc

+++ b/chrome/browser/ui/android/infobars/infobar_container_android.cc

@@ -65,7 +65,7 @@ void InfoBarContainerAndroid::AttachJavaInfoBar(InfoBarAndroid* android_bar) {

JNIEnv* env = base::android::AttachCurrentThread();

if (Java_InfoBarContainer_nextInfoBarWillBeVisible(

- env, weak_java_infobar_container_.get(env).obj())) {

+ env, weak_java_infobar_container_.get(env))) {

UMA_HISTOGRAM_SPARSE_SLOWLY("InfoBar.Shown.Visible",

android_bar->delegate()->GetIdentifier());

} else {

@@ -75,8 +75,8 @@ void InfoBarContainerAndroid::AttachJavaInfoBar(InfoBarAndroid* android_bar) {

base::android::ScopedJavaLocalRef<jobject> java_infobar =

android_bar->CreateRenderInfoBar(env);

- Java_InfoBarContainer_addInfoBar(

- env, weak_java_infobar_container_.get(env).obj(), java_infobar.obj());

+ Java_InfoBarContainer_addInfoBar(env, weak_java_infobar_container_.get(env),

+ java_infobar);

android_bar->SetJavaInfoBar(java_infobar);

}