Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: blimp/client/app/android/toolbar.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/app/android/blimp_view.cc ('k') | blimp/client/app/android/web_input_box.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/app/android/toolbar.cc
diff --git a/blimp/client/app/android/toolbar.cc b/blimp/client/app/android/toolbar.cc
index f9f8f05108d4928b58bbb9e1fe68e14c455609d3..864d410fcd5bd83989def6c05f474fd7ed18cdc7 100644
--- a/blimp/client/app/android/toolbar.cc
+++ b/blimp/client/app/android/toolbar.cc
@@ -92,14 +92,14 @@ void Toolbar::OnUrlChanged(int tab_id, const GURL& url) {
ScopedJavaLocalRef<jstring> jurl(
base::android::ConvertUTF8ToJavaString(env, url.spec()));
- Java_Toolbar_onEngineSentUrl(env, java_obj_.obj(), jurl.obj());
+ Java_Toolbar_onEngineSentUrl(env, java_obj_, jurl);
}
void Toolbar::OnFaviconChanged(int tab_id, const SkBitmap& favicon) {
JNIEnv* env = base::android::AttachCurrentThread();
ScopedJavaLocalRef<jobject> jfavicon(gfx::ConvertToJavaBitmap(&favicon));
- Java_Toolbar_onEngineSentFavicon(env, java_obj_.obj(), jfavicon.obj());
+ Java_Toolbar_onEngineSentFavicon(env, java_obj_, jfavicon);
}
void Toolbar::OnTitleChanged(int tab_id, const std::string& title) {
@@ -107,14 +107,13 @@ void Toolbar::OnTitleChanged(int tab_id, const std::string& title) {
ScopedJavaLocalRef<jstring> jtitle(
base::android::ConvertUTF8ToJavaString(env, title));
- Java_Toolbar_onEngineSentTitle(env, java_obj_.obj(), jtitle.obj());
+ Java_Toolbar_onEngineSentTitle(env, java_obj_, jtitle);
}
void Toolbar::OnLoadingChanged(int tab_id, bool loading) {
JNIEnv* env = base::android::AttachCurrentThread();
- Java_Toolbar_onEngineSentLoading(env,
- java_obj_.obj(),
+ Java_Toolbar_onEngineSentLoading(env, java_obj_,
static_cast<jboolean>(loading));
}
@@ -122,9 +121,7 @@ void Toolbar::OnPageLoadStatusUpdate(int tab_id, bool completed) {
JNIEnv* env = base::android::AttachCurrentThread();
Java_Toolbar_onEngineSentPageLoadStatusUpdate(
- env,
- java_obj_.obj(),
- static_cast<jboolean>(completed));
+ env, java_obj_, static_cast<jboolean>(completed));
}
} // namespace client
« no previous file with comments | « blimp/client/app/android/blimp_view.cc ('k') | blimp/client/app/android/web_input_box.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698