Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chrome/browser/android/download/chrome_download_delegate.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/download/chrome_download_delegate.cc
diff --git a/chrome/browser/android/download/chrome_download_delegate.cc b/chrome/browser/android/download/chrome_download_delegate.cc
index e8398e765c024792c0e8445927b4e911374b39d6..256e6f4573377237d2ba7e9d6a7b5d36c6f33d4e 100644
--- a/chrome/browser/android/download/chrome_download_delegate.cc
+++ b/chrome/browser/android/download/chrome_download_delegate.cc
@@ -171,10 +171,9 @@ void ChromeDownloadDelegate::RequestHTTPGetDownload(
ScopedJavaLocalRef<jstring> jfilename =
base::android::ConvertUTF16ToJavaString(env, file_name);
Java_ChromeDownloadDelegate_requestHttpGetDownload(
- env, java_ref_,
- jurl.obj(), juser_agent.obj(), jcontent_disposition.obj(),
- jmime_type.obj(), jcookie.obj(), jreferer.obj(), has_user_gesture,
- jfilename.obj(), content_length, must_download);
+ env, java_ref_, jurl, juser_agent, jcontent_disposition, jmime_type,
+ jcookie, jreferer, has_user_gesture, jfilename, content_length,
+ must_download);
}
void ChromeDownloadDelegate::OnDownloadStarted(const std::string& filename,
@@ -184,8 +183,8 @@ void ChromeDownloadDelegate::OnDownloadStarted(const std::string& filename,
env, filename);
ScopedJavaLocalRef<jstring> jmime_type =
ConvertUTF8ToJavaString(env, mime_type);
- Java_ChromeDownloadDelegate_onDownloadStarted(
- env, java_ref_, jfilename.obj(), jmime_type.obj());
+ Java_ChromeDownloadDelegate_onDownloadStarted(env, java_ref_, jfilename,
+ jmime_type);
}
void ChromeDownloadDelegate::OnDangerousDownload(const std::string& filename,
@@ -194,8 +193,8 @@ void ChromeDownloadDelegate::OnDangerousDownload(const std::string& filename,
ScopedJavaLocalRef<jstring> jfilename = ConvertUTF8ToJavaString(
env, filename);
ScopedJavaLocalRef<jstring> jguid = ConvertUTF8ToJavaString(env, guid);
- Java_ChromeDownloadDelegate_onDangerousDownload(
- env, java_ref_, jfilename.obj(), jguid.obj());
+ Java_ChromeDownloadDelegate_onDangerousDownload(env, java_ref_, jfilename,
+ jguid);
}
void ChromeDownloadDelegate::RequestFileAccess(intptr_t callback_id) {

Powered by Google App Engine
This is Rietveld 408576698