Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index fe993cc4193a83b0dbc1b3c178c772c9971c27cf..b25d564d663b6d50cfd32691a46bfdb8d2285565 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -50,7 +50,7 @@ AppBannerManagerAndroid::AppBannerManagerAndroid(
AppBannerManagerAndroid::~AppBannerManagerAndroid() {
JNIEnv* env = base::android::AttachCurrentThread();
- Java_AppBannerManager_destroy(env, java_banner_manager_.obj());
+ Java_AppBannerManager_destroy(env, java_banner_manager_);
java_banner_manager_.Reset();
}
@@ -104,7 +104,7 @@ bool AppBannerManagerAndroid::OnAppDetailsRetrieved(
void AppBannerManagerAndroid::RequestAppBanner(const GURL& validated_url,
bool is_debug_mode) {
JNIEnv* env = base::android::AttachCurrentThread();
- if (!Java_AppBannerManager_isEnabledForTab(env, java_banner_manager_.obj()))
+ if (!Java_AppBannerManager_isEnabledForTab(env, java_banner_manager_))
return;
AppBannerManager::RequestAppBanner(validated_url, is_debug_mode);
@@ -245,9 +245,9 @@ bool AppBannerManagerAndroid::CanHandleNonWebApp(const std::string& platform,
ConvertUTF8ToJavaString(env, validated_url_.spec()));
ScopedJavaLocalRef<jstring> jpackage(ConvertUTF8ToJavaString(env, id));
ScopedJavaLocalRef<jstring> jreferrer(ConvertUTF8ToJavaString(env, referrer));
- Java_AppBannerManager_fetchAppDetails(
- env, java_banner_manager_.obj(), jurl.obj(), jpackage.obj(),
- jreferrer.obj(), GetIdealIconSizeInDp());
+ Java_AppBannerManager_fetchAppDetails(env, java_banner_manager_, jurl,
+ jpackage, jreferrer,
+ GetIdealIconSizeInDp());
return true;
}

Powered by Google App Engine
This is Rietveld 408576698