android_webview/native/permission/aw_permission_request.cc - Issue 2237943002: Remove now-unnecessary .obj() in Java method calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/permission/aw_permission_request.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context

Patch Set: Rebase *again* :( Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/java_browser_view_renderer_helper.cc ('k') | android_webview/native/token_binding_manager_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/permission/aw_permission_request.cc

diff --git a/android_webview/native/permission/aw_permission_request.cc b/android_webview/native/permission/aw_permission_request.cc

index 1c1e34b19c16cc3332d329f9f1ddbb8d703d2903..4f2f09b8c8f3e0b746207757fc2a994dcd1625e8 100644

--- a/android_webview/native/permission/aw_permission_request.cc

+++ b/android_webview/native/permission/aw_permission_request.cc

@@ -38,7 +38,7 @@ AwPermissionRequest::AwPermissionRequest(

JNIEnv* env = AttachCurrentThread();

*java_peer = Java_AwPermissionRequest_create(

env, reinterpret_cast<jlong>(this),

- ConvertUTF8ToJavaString(env, GetOrigin().spec()).obj(), GetResources());

+ ConvertUTF8ToJavaString(env, GetOrigin().spec()), GetResources());

java_ref_ = JavaObjectWeakGlobalRef(env, java_peer->obj());

}

@@ -63,8 +63,7 @@ void AwPermissionRequest::DeleteThis() {

ScopedJavaLocalRef<jobject> j_request = GetJavaObject();

if (j_request.is_null())

return;

- Java_AwPermissionRequest_destroyNative(AttachCurrentThread(),

- j_request.obj());

+ Java_AwPermissionRequest_destroyNative(AttachCurrentThread(), j_request);

}

void AwPermissionRequest::Destroy(JNIEnv* env,