chrome/browser/password_manager/credential_android.cc - Issue 2237943002: Remove now-unnecessary .obj() in Java method calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/credential_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context

Patch Set: Rebase *again* :( Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc ('k') | chrome/browser/permissions/permission_update_infobar_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/credential_android.cc

diff --git a/chrome/browser/password_manager/credential_android.cc b/chrome/browser/password_manager/credential_android.cc

index d669ad8923767ea139ed22852d727055fe113743..0a49ca844671c61ca6e2f0fd3b4c25cc4f6d81b6 100644

--- a/chrome/browser/password_manager/credential_android.cc

+++ b/chrome/browser/password_manager/credential_android.cc

@@ -25,9 +25,9 @@ base::android::ScopedJavaLocalRef<jobject> CreateNativeCredential(

IDS_PASSWORDS_VIA_FEDERATION,

base::ASCIIToUTF16(password_form.federation_origin.host()));

return Java_Credential_createCredential(

- env, ConvertUTF16ToJavaString(env, password_form.username_value).obj(),

- ConvertUTF16ToJavaString(env, password_form.display_name).obj(),

- ConvertUTF8ToJavaString(env, federation).obj(), type, position);

+ env, ConvertUTF16ToJavaString(env, password_form.username_value),

+ ConvertUTF16ToJavaString(env, password_form.display_name),

+ ConvertUTF8ToJavaString(env, federation), type, position);

}

base::android::ScopedJavaLocalRef<jobjectArray> CreateNativeCredentialArray(