Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: components/navigation_interception/navigation_params_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/navigation_interception/navigation_params_android.h" 5 #include "components/navigation_interception/navigation_params_android.h"
6 6
7 #include "base/android/jni_string.h" 7 #include "base/android/jni_string.h"
8 #include "jni/NavigationParams_jni.h" 8 #include "jni/NavigationParams_jni.h"
9 9
10 using base::android::ConvertUTF8ToJavaString; 10 using base::android::ConvertUTF8ToJavaString;
11 using base::android::ScopedJavaLocalRef; 11 using base::android::ScopedJavaLocalRef;
12 12
13 namespace navigation_interception { 13 namespace navigation_interception {
14 14
15 base::android::ScopedJavaLocalRef<jobject> CreateJavaNavigationParams( 15 base::android::ScopedJavaLocalRef<jobject> CreateJavaNavigationParams(
16 JNIEnv* env, 16 JNIEnv* env,
17 const NavigationParams& params, 17 const NavigationParams& params,
18 bool has_user_gesture_carryover) { 18 bool has_user_gesture_carryover) {
19 ScopedJavaLocalRef<jstring> jstring_url = 19 ScopedJavaLocalRef<jstring> jstring_url =
20 ConvertUTF8ToJavaString(env, params.url().spec()); 20 ConvertUTF8ToJavaString(env, params.url().spec());
21 21
22 ScopedJavaLocalRef<jstring> jstring_referrer = 22 ScopedJavaLocalRef<jstring> jstring_referrer =
23 ConvertUTF8ToJavaString(env, params.referrer().url.spec()); 23 ConvertUTF8ToJavaString(env, params.referrer().url.spec());
24 24
25 return Java_NavigationParams_create( 25 return Java_NavigationParams_create(
26 env, 26 env, jstring_url, jstring_referrer, params.is_post(),
27 jstring_url.obj(), 27 params.has_user_gesture(), params.transition_type(), params.is_redirect(),
28 jstring_referrer.obj(), 28 params.is_external_protocol(), params.is_main_frame(),
29 params.is_post(),
30 params.has_user_gesture(),
31 params.transition_type(),
32 params.is_redirect(),
33 params.is_external_protocol(),
34 params.is_main_frame(),
35 has_user_gesture_carryover); 29 has_user_gesture_carryover);
36 } 30 }
37 31
38 } // namespace navigation_interception 32 } // namespace navigation_interception
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698