Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: base/android/content_uri_utils.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/android/callback_android.cc ('k') | base/android/java_handler_thread.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/content_uri_utils.h" 5 #include "base/android/content_uri_utils.h"
6 6
7 #include "base/android/context_utils.h" 7 #include "base/android/context_utils.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "jni/ContentUriUtils_jni.h" 10 #include "jni/ContentUriUtils_jni.h"
11 11
12 using base::android::ConvertUTF8ToJavaString; 12 using base::android::ConvertUTF8ToJavaString;
13 using base::android::ScopedJavaLocalRef; 13 using base::android::ScopedJavaLocalRef;
14 14
15 namespace base { 15 namespace base {
16 16
17 bool ContentUriExists(const FilePath& content_uri) { 17 bool ContentUriExists(const FilePath& content_uri) {
18 JNIEnv* env = base::android::AttachCurrentThread(); 18 JNIEnv* env = base::android::AttachCurrentThread();
19 ScopedJavaLocalRef<jstring> j_uri = 19 ScopedJavaLocalRef<jstring> j_uri =
20 ConvertUTF8ToJavaString(env, content_uri.value()); 20 ConvertUTF8ToJavaString(env, content_uri.value());
21 return Java_ContentUriUtils_contentUriExists( 21 return Java_ContentUriUtils_contentUriExists(
22 env, base::android::GetApplicationContext(), j_uri.obj()); 22 env, base::android::GetApplicationContext(), j_uri);
23 } 23 }
24 24
25 File OpenContentUriForRead(const FilePath& content_uri) { 25 File OpenContentUriForRead(const FilePath& content_uri) {
26 JNIEnv* env = base::android::AttachCurrentThread(); 26 JNIEnv* env = base::android::AttachCurrentThread();
27 ScopedJavaLocalRef<jstring> j_uri = 27 ScopedJavaLocalRef<jstring> j_uri =
28 ConvertUTF8ToJavaString(env, content_uri.value()); 28 ConvertUTF8ToJavaString(env, content_uri.value());
29 jint fd = Java_ContentUriUtils_openContentUriForRead( 29 jint fd = Java_ContentUriUtils_openContentUriForRead(
30 env, base::android::GetApplicationContext(), j_uri.obj()); 30 env, base::android::GetApplicationContext(), j_uri);
31 if (fd < 0) 31 if (fd < 0)
32 return File(); 32 return File();
33 return File(fd); 33 return File(fd);
34 } 34 }
35 35
36 std::string GetContentUriMimeType(const FilePath& content_uri) { 36 std::string GetContentUriMimeType(const FilePath& content_uri) {
37 JNIEnv* env = base::android::AttachCurrentThread(); 37 JNIEnv* env = base::android::AttachCurrentThread();
38 ScopedJavaLocalRef<jstring> j_uri = 38 ScopedJavaLocalRef<jstring> j_uri =
39 ConvertUTF8ToJavaString(env, content_uri.value()); 39 ConvertUTF8ToJavaString(env, content_uri.value());
40 ScopedJavaLocalRef<jstring> j_mime = 40 ScopedJavaLocalRef<jstring> j_mime = Java_ContentUriUtils_getMimeType(
41 Java_ContentUriUtils_getMimeType( 41 env, base::android::GetApplicationContext(), j_uri);
42 env, base::android::GetApplicationContext(), j_uri.obj());
43 if (j_mime.is_null()) 42 if (j_mime.is_null())
44 return std::string(); 43 return std::string();
45 44
46 return base::android::ConvertJavaStringToUTF8(env, j_mime.obj()); 45 return base::android::ConvertJavaStringToUTF8(env, j_mime.obj());
47 } 46 }
48 47
49 } // namespace base 48 } // namespace base
OLDNEW
« no previous file with comments | « base/android/callback_android.cc ('k') | base/android/java_handler_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698