Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4598)

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
index 0ad21075ba9ada510de7f309aa2c1b0972765eaf..aa03a7d8e1665feab06ef6b40cbbe2344bf98778 100644
--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
@@ -87,8 +87,7 @@ AppBannerInfoBarDelegateAndroid::~AppBannerInfoBarDelegateAndroid() {
TrackDismissEvent(DISMISS_EVENT_DISMISSED);
JNIEnv* env = base::android::AttachCurrentThread();
- Java_AppBannerInfoBarDelegateAndroid_destroy(env,
- java_delegate_.obj());
+ Java_AppBannerInfoBarDelegateAndroid_destroy(env, java_delegate_);
java_delegate_.Reset();
}
@@ -99,9 +98,7 @@ void AppBannerInfoBarDelegateAndroid::UpdateInstallState(
return;
int newState = Java_AppBannerInfoBarDelegateAndroid_determineInstallState(
- env,
- java_delegate_.obj(),
- native_app_data_.obj());
+ env, java_delegate_, native_app_data_);
static_cast<AppBannerInfoBarAndroid*>(infobar())
->OnInstallStateChanged(newState);
}
@@ -232,12 +229,10 @@ bool AppBannerInfoBarDelegateAndroid::Accept() {
ScopedJavaLocalRef<jstring> jreferrer(
ConvertUTF8ToJavaString(env, referrer_));
- bool was_opened = Java_AppBannerInfoBarDelegateAndroid_installOrOpenNativeApp(
- env,
- java_delegate_.obj(),
- tab->GetJavaObject().obj(),
- native_app_data_.obj(),
- jreferrer.obj());
+ bool was_opened =
+ Java_AppBannerInfoBarDelegateAndroid_installOrOpenNativeApp(
+ env, java_delegate_, tab->GetJavaObject(), native_app_data_,
+ jreferrer);
if (was_opened) {
TrackDismissEvent(DISMISS_EVENT_APP_OPEN);
@@ -290,10 +285,8 @@ bool AppBannerInfoBarDelegateAndroid::LinkClicked(
return true;
}
- Java_AppBannerInfoBarDelegateAndroid_showAppDetails(env,
- java_delegate_.obj(),
- tab->GetJavaObject().obj(),
- native_app_data_.obj());
+ Java_AppBannerInfoBarDelegateAndroid_showAppDetails(
+ env, java_delegate_, tab->GetJavaObject(), native_app_data_);
TrackDismissEvent(DISMISS_EVENT_BANNER_CLICK);
return true;

Powered by Google App Engine
This is Rietveld 408576698