Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Side by Side Diff: content/browser/android/background_sync_network_observer_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/android/background_sync_network_observer_android.h" 5 #include "content/browser/android/background_sync_network_observer_android.h"
6 6
7 #include "base/android/context_utils.h" 7 #include "base/android/context_utils.h"
8 #include "jni/BackgroundSyncNetworkObserver_jni.h" 8 #include "jni/BackgroundSyncNetworkObserver_jni.h"
9 9
10 using base::android::JavaParamRef; 10 using base::android::JavaParamRef;
(...skipping 28 matching lines...) Expand all
39 base::android::ScopedJavaGlobalRef<jobject> obj( 39 base::android::ScopedJavaGlobalRef<jobject> obj(
40 Java_BackgroundSyncNetworkObserver_createObserver( 40 Java_BackgroundSyncNetworkObserver_createObserver(
41 env, base::android::GetApplicationContext(), 41 env, base::android::GetApplicationContext(),
42 reinterpret_cast<jlong>(this))); 42 reinterpret_cast<jlong>(this)));
43 j_observer_.Reset(obj); 43 j_observer_.Reset(obj);
44 } 44 }
45 45
46 BackgroundSyncNetworkObserverAndroid::Observer::~Observer() { 46 BackgroundSyncNetworkObserverAndroid::Observer::~Observer() {
47 JNIEnv* env = base::android::AttachCurrentThread(); 47 JNIEnv* env = base::android::AttachCurrentThread();
48 Java_BackgroundSyncNetworkObserver_removeObserver( 48 Java_BackgroundSyncNetworkObserver_removeObserver(
49 env, j_observer_.obj(), reinterpret_cast<jlong>(this)); 49 env, j_observer_, reinterpret_cast<jlong>(this));
50 DCHECK_CURRENTLY_ON(BrowserThread::UI); 50 DCHECK_CURRENTLY_ON(BrowserThread::UI);
51 j_observer_.Release(); 51 j_observer_.Release();
52 } 52 }
53 53
54 void BackgroundSyncNetworkObserverAndroid::Observer:: 54 void BackgroundSyncNetworkObserverAndroid::Observer::
55 NotifyConnectionTypeChanged(JNIEnv* env, 55 NotifyConnectionTypeChanged(JNIEnv* env,
56 const JavaParamRef<jobject>& jcaller, 56 const JavaParamRef<jobject>& jcaller,
57 jint new_connection_type) { 57 jint new_connection_type) {
58 DCHECK_CURRENTLY_ON(BrowserThread::UI); 58 DCHECK_CURRENTLY_ON(BrowserThread::UI);
59 BrowserThread::PostTask( 59 BrowserThread::PostTask(
(...skipping 20 matching lines...) Expand all
80 80
81 observer_ = Observer::Create( 81 observer_ = Observer::Create(
82 base::Bind(&BackgroundSyncNetworkObserverAndroid::OnNetworkChanged, 82 base::Bind(&BackgroundSyncNetworkObserverAndroid::OnNetworkChanged,
83 weak_ptr_factory_.GetWeakPtr())); 83 weak_ptr_factory_.GetWeakPtr()));
84 } 84 }
85 85
86 BackgroundSyncNetworkObserverAndroid::~BackgroundSyncNetworkObserverAndroid() { 86 BackgroundSyncNetworkObserverAndroid::~BackgroundSyncNetworkObserverAndroid() {
87 DCHECK_CURRENTLY_ON(BrowserThread::IO); 87 DCHECK_CURRENTLY_ON(BrowserThread::IO);
88 } 88 }
89 } // namespace content 89 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698