chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc - Issue 2237943002: Remove now-unnecessary .obj() in Java method calls.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context

Patch Set: Rebase *again* :( Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/android/javascript_app_modal_dialog_android.cc ('k') | chrome/browser/ui/android/ssl_client_certificate_request.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.h"	5 #include "chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.h"

6	6

7 #include "base/android/jni_android.h"	7 #include "base/android/jni_android.h"

8 #include "base/android/jni_string.h"	8 #include "base/android/jni_string.h"

9 #include "chrome/browser/android/tab_android.h"	9 #include "chrome/browser/android/tab_android.h"

10 #include "chrome/browser/profiles/profile.h"	10 #include "chrome/browser/profiles/profile.h"

(...skipping 10 matching lines...) Expand all Loading...
21 base::string16 message = l10n_util::GetStringFUTF16(	21 base::string16 message = l10n_util::GetStringFUTF16(

22 IDS_MANAGE_PASSWORDS_AUTO_SIGNIN_TITLE, username);	22 IDS_MANAGE_PASSWORDS_AUTO_SIGNIN_TITLE, username);

23	23

24 JNIEnv* env = base::android::AttachCurrentThread();	24 JNIEnv* env = base::android::AttachCurrentThread();

25 TabAndroid* tab = TabAndroid::FromWebContents(web_contents);	25 TabAndroid* tab = TabAndroid::FromWebContents(web_contents);

26 // TODO(melandory): https://crbug.com/590838 Introduce proper fix.	26 // TODO(melandory): https://crbug.com/590838 Introduce proper fix.

27 if (tab == nullptr)	27 if (tab == nullptr)

28 return;	28 return;

29 ScopedJavaLocalRef<jstring> java_message =	29 ScopedJavaLocalRef<jstring> java_message =

30 base::android::ConvertUTF16ToJavaString(env, message);	30 base::android::ConvertUTF16ToJavaString(env, message);

31 Java_AutoSigninSnackbarController_showSnackbar(	31 Java_AutoSigninSnackbarController_showSnackbar(env, tab->GetJavaObject(),

32 env, tab->GetJavaObject().obj(), java_message.obj());	32 java_message);

33 }	33 }

34	34

OLD	NEW