Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5546)

Unified Diff: chrome/browser/ui/android/infobars/app_banner_infobar_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context
Patch Set: Rebase *again* :( Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/infobars/app_banner_infobar_android.cc
diff --git a/chrome/browser/ui/android/infobars/app_banner_infobar_android.cc b/chrome/browser/ui/android/infobars/app_banner_infobar_android.cc
index fbb3b71e97d97274fca072fd4ef5678a3313294c..2d558e9254f06c9d31cbbabc639de405577233bc 100644
--- a/chrome/browser/ui/android/infobars/app_banner_infobar_android.cc
+++ b/chrome/browser/ui/android/infobars/app_banner_infobar_android.cc
@@ -45,10 +45,7 @@ AppBannerInfoBarAndroid::CreateRenderInfoBar(JNIEnv* env) {
base::android::ScopedJavaLocalRef<jobject> infobar;
if (!japp_data_.is_null()) {
infobar.Reset(Java_AppBannerInfoBarAndroid_createNativeAppInfoBar(
- env,
- app_title.obj(),
- java_bitmap.obj(),
- japp_data_.obj()));
+ env, app_title, java_bitmap, japp_data_));
} else {
// Trim down the app URL to the domain and registry.
std::string trimmed_url =
@@ -60,10 +57,7 @@ AppBannerInfoBarAndroid::CreateRenderInfoBar(JNIEnv* env) {
base::android::ConvertUTF8ToJavaString(env, trimmed_url);
infobar.Reset(Java_AppBannerInfoBarAndroid_createWebAppInfoBar(
- env,
- app_title.obj(),
- java_bitmap.obj(),
- app_url.obj()));
+ env, app_title, java_bitmap, app_url));
}
java_infobar_.Reset(env, infobar.obj());
@@ -72,7 +66,7 @@ AppBannerInfoBarAndroid::CreateRenderInfoBar(JNIEnv* env) {
void AppBannerInfoBarAndroid::OnInstallStateChanged(int new_state) {
JNIEnv* env = base::android::AttachCurrentThread();
- Java_AppBannerInfoBarAndroid_onInstallStateChanged(env, java_infobar_.obj(),
+ Java_AppBannerInfoBarAndroid_onInstallStateChanged(env, java_infobar_,
new_state);
}

Powered by Google App Engine
This is Rietveld 408576698