device/bluetooth/bluetooth_remote_gatt_descriptor_android.cc - Issue 2237943002: Remove now-unnecessary .obj() in Java method calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_remote_gatt_descriptor_android.cc

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@switch-context

Patch Set: Rebase *again* :( Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc ('k') | device/bluetooth/bluetooth_remote_gatt_service_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_remote_gatt_descriptor_android.cc

diff --git a/device/bluetooth/bluetooth_remote_gatt_descriptor_android.cc b/device/bluetooth/bluetooth_remote_gatt_descriptor_android.cc

index 62a405a124ad2d91849736aefeef0003b11c97ea..0708a3bafb6a1681ea8924735f36b73b167b4cc6 100644

--- a/device/bluetooth/bluetooth_remote_gatt_descriptor_android.cc

+++ b/device/bluetooth/bluetooth_remote_gatt_descriptor_android.cc

@@ -44,7 +44,7 @@ BluetoothRemoteGattDescriptorAndroid::Create(

BluetoothRemoteGattDescriptorAndroid::~BluetoothRemoteGattDescriptorAndroid() {

Java_ChromeBluetoothRemoteGattDescriptor_onBluetoothRemoteGattDescriptorAndroidDestruction(

- AttachCurrentThread(), j_descriptor_.obj());

+ AttachCurrentThread(), j_descriptor_);

}

// static

@@ -65,7 +65,7 @@ std::string BluetoothRemoteGattDescriptorAndroid::GetIdentifier() const {

BluetoothUUID BluetoothRemoteGattDescriptorAndroid::GetUUID() const {

return device::BluetoothUUID(

ConvertJavaStringToUTF8(Java_ChromeBluetoothRemoteGattDescriptor_getUUID(

- AttachCurrentThread(), j_descriptor_.obj())));

+ AttachCurrentThread(), j_descriptor_)));

}

const std::vector<uint8_t>& BluetoothRemoteGattDescriptorAndroid::GetValue()

@@ -97,7 +97,7 @@ void BluetoothRemoteGattDescriptorAndroid::ReadRemoteDescriptor(

}

if (!Java_ChromeBluetoothRemoteGattDescriptor_readRemoteDescriptor(

- AttachCurrentThread(), j_descriptor_.obj())) {

+ AttachCurrentThread(), j_descriptor_)) {

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(error_callback,

@@ -124,8 +124,7 @@ void BluetoothRemoteGattDescriptorAndroid::WriteRemoteDescriptor(

JNIEnv* env = AttachCurrentThread();

if (!Java_ChromeBluetoothRemoteGattDescriptor_writeRemoteDescriptor(

- env, j_descriptor_.obj(),

- base::android::ToJavaByteArray(env, new_value).obj())) {

+ env, j_descriptor_, base::android::ToJavaByteArray(env, new_value))) {

base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(error_callback,