Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2861)

Issue 2237943002: Remove now-unnecessary .obj() in Java method calls. (Closed)

Created:
3 years, 12 months ago by Torne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, dominickn+watch_chromium.org, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, johnme+watch_chromium.org, groby+spellwatch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, scheib+watch_chromium.org, kmarshall+watch-blimp_chromium.org, dmazzoni+watch_chromium.org, mlamouri+watch-content_chromium.org, ben+mojo_chromium.org, shaktisahu+watch-blimp_chromium.org, mlamouri+watch-media_chromium.org, dimich+watch_chromium.org, timvolodine, darin-cc_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, dewittj+watch_chromium.org, toyoshim+midi_chromium.org, Aaron Boodman, aboxhall+watch_chromium.org, fgorski+watch_chromium.org, chromoting-reviews_chromium.org, jam, chasej+watch_chromium.org, abarth-chromium, rouslan+autofill_chromium.org, marcinjb+watch-blimp_chromium.org, je_julie, wifiprefetch-reviews_google.com, jkarlin+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, vabr+watchlistautofill_chromium.org, rlp+watch_chromium.org, miu+watch_chromium.org, android-webview-reviews_chromium.org, dtapuska+chromiumwatch_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, ntp-dev+reviews_chromium.org, tdresser+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, jochen+watch_chromium.org, twellington+watch_chromium.org, pam+watch_chromium.org, petewil+watch_chromium.org, mcasas+watch+vc_chromium.org, mlamouri+watch-sensors_chromium.org, mlamouri+watch-permissions_chromium.org, gcasto+watchlist_chromium.org, khushalsagar+watch-blimp_chromium.org, loading-reviews+metrics_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, romax+watch_chromium.org, riju_, donnd+watch_chromium.org, nektar+watch_chromium.org, csharrison+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, asvitkine+watch_chromium.org, iclelland+watch_chromium.org, sync-reviews_chromium.org, ortuno+watch_chromium.org, dtseng+watch_chromium.org, chili+watch_chromium.org, estade+watch_chromium.org, darin (slow to review), dtrainor+watch-blimp_chromium.org, dcheng, jshin+watch_chromium.org, rouslan+spell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@switch-context
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove now-unnecessary .obj() in Java method calls. Java methods can now be passed JavaRef parameters directly; remove calls to .obj() that were being used to convert JavaRef to bare jobject, in preparation for requiring JavaRef to be used. This CL only fixes cases that can be fixed by removing the precise string ".obj()" from a function call and does not introduce any other changes (though it was run through git cl format to rewrap lines afterward). This is to enable rubberstamp reviews. There are a much smaller number of nontrivial changes required to completely eliminate use of bare jobject as Java method parameters, which will come in followup CLs for proper review. BUG=506850 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/948f366645b6e37e2a43bac70c07a8d5c7e592eb Cr-Commit-Position: refs/heads/master@{#412237}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase *again* :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1687 lines, -2302 lines) Patch
M android_webview/native/android_protocol_handler.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M android_webview/native/aw_autofill_client.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M android_webview/native/aw_contents.cc View 23 chunks +32 lines, -52 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge.cc View 6 chunks +12 lines, -22 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.cc View 10 chunks +23 lines, -44 lines 0 comments Download
M android_webview/native/aw_gl_functor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_http_auth_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_message_port_service_impl.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M android_webview/native/aw_pdf_exporter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/aw_quota_manager_bridge_impl.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M android_webview/native/aw_web_resource_response_impl.cc View 5 chunks +7 lines, -10 lines 0 comments Download
M android_webview/native/cookie_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/native/input_stream_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M android_webview/native/java_browser_view_renderer_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/native/permission/aw_permission_request.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M android_webview/native/token_binding_manager_bridge.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M base/android/apk_assets.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M base/android/callback_android.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M base/android/content_uri_utils.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M base/android/java_handler_thread.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M base/android/java_runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/android/jni_generator/sample_for_tests.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M base/message_loop/message_pump_android.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M base/test/test_file_util_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/app/android/blimp_client_session_android.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M blimp/client/app/android/blimp_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/app/android/toolbar.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M blimp/client/app/android/web_input_box.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M blimp/client/core/android/blimp_client_context_impl_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/client/core/android/dummy_blimp_client_context_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/contents/android/blimp_contents_impl_android.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M blimp/client/core/contents/android/blimp_contents_observer_proxy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M blimp/client/core/contents/android/blimp_navigation_controller_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/accessibility/font_size_prefs_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/background_sync_launcher_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/banners/app_banner_infobar_delegate_android.cc View 1 4 chunks +8 lines, -15 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager_android.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/android/blimp/chrome_blimp_client_context_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/bookmarks/bookmark_bridge.cc View 17 chunks +28 lines, -51 lines 0 comments Download
M chrome/browser/android/bottombar/overlay_panel_content.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_application.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/android/compositor/compositor_view.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/android/compositor/scene_layer/scene_layer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/android/compositor/tab_content_manager.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_manager.cc View 5 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/android/contextualsearch/contextual_search_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/cookies/cookies_fetcher.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/android/data_usage/external_data_use_observer_bridge.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/android/dom_distiller/distiller_ui_handle_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/download/chrome_download_delegate.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/android/download/download_controller.cc View 3 chunks +11 lines, -15 lines 0 comments Download
M chrome/browser/android/download/download_manager_service.cc View 6 chunks +20 lines, -33 lines 0 comments Download
M chrome/browser/android/favicon_helper.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/android/foreign_session_helper.cc View 5 chunks +11 lines, -21 lines 0 comments Download
M chrome/browser/android/history_report/history_report_jni_bridge.cc View 3 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/android/intent_helper.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/android/large_icon_bridge.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/android/location_settings_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/logo_bridge.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/android/mojo/chrome_interface_registrar_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/net/external_estimate_provider_android.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/android/ntp/most_visited_sites_bridge.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/android/ntp/ntp_snippets_launcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/offline_pages/background_scheduler_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_bridge.cc View 1 8 chunks +21 lines, -22 lines 0 comments Download
M chrome/browser/android/omnibox/answers_image_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/omnibox/autocomplete_controller_android.cc View 4 chunks +12 lines, -22 lines 0 comments Download
M chrome/browser/android/password_ui_view_android.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/android/precache/precache_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/android/preferences/pref_service_bridge.cc View 1 5 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/android/preferences/website_preference_bridge.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/android/profiles/profile_downloader_android.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/android/provider/chrome_browser_provider.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/recently_closed_tabs_bridge.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/android/safe_browsing/safe_browsing_api_handler_bridge.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/android/service_tab_launcher.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 7 chunks +14 lines, -27 lines 0 comments Download
M chrome/browser/android/signin/account_management_screen_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/signin/signin_manager_android.cc View 4 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/android/signin/signin_promo_util_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/tab_android.cc View 1 10 chunks +18 lines, -28 lines 0 comments Download
M chrome/browser/android/tab_web_contents_delegate_android.cc View 5 chunks +14 lines, -34 lines 0 comments Download
M chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M chrome/browser/android/webapk/webapk_installer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc View 1 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/android/webapps/webapp_registry.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 5 chunks +51 lines, -61 lines 0 comments Download
M chrome/browser/media/android/cdm/media_drm_credential_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/android/remote/remote_media_player_bridge.cc View 14 chunks +22 lines, -30 lines 0 comments Download
M chrome/browser/media/android/router/media_router_android.cc View 8 chunks +19 lines, -40 lines 0 comments Download
M chrome/browser/media/android/router/media_router_dialog_controller_android.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/notifications/notification_platform_bridge_android.cc View 4 chunks +9 lines, -11 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/password_manager/account_chooser_dialog_android.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/password_manager/credential_android.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/permissions/permission_update_infobar_delegate_android.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/platform_util_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_android.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/signin/oauth2_token_service_delegate_android.cc View 1 9 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/speech/tts_android.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/spellchecker/spellchecker_session_bridge_android.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/supervised_user/child_accounts/child_account_feedback_reporter_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_content_provider_android.cc View 4 chunks +12 lines, -17 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.cc View 6 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_logger_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_popup_view_android.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M chrome/browser/ui/android/autofill/card_unmask_prompt_view_android.cc View 4 chunks +15 lines, -17 lines 0 comments Download
M chrome/browser/ui/android/autofill/credit_card_scanner_view_android.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/ui/android/bluetooth_chooser_android.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/android/chrome_http_auth_handler.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/android/connection_info_popup_android.cc View 1 2 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/ui/android/context_menu_helper.cc View 1 4 chunks +15 lines, -20 lines 0 comments Download
M chrome/browser/ui/android/infobars/app_banner_infobar_android.cc View 3 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/ui/android/infobars/autofill_credit_card_filling_infobar.cc View 1 chunk +7 lines, -13 lines 0 comments Download
M chrome/browser/ui/android/infobars/autofill_save_card_infobar.cc View 1 chunk +12 lines, -16 lines 0 comments Download
M chrome/browser/ui/android/infobars/confirm_infobar.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/infobars/download_overwrite_infobar.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/infobars/generated_password_saved_infobar.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/infobars/grouped_permission_infobar.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/android/infobars/infobar_android.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/infobars/infobar_container_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/infobars/save_password_infobar.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/infobars/simple_confirm_infobar_builder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/infobars/translate_infobar.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/android/infobars/update_password_infobar.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/javascript_app_modal_dialog_android.cc View 3 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/ui/android/snackbars/auto_signin_prompt_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/ssl_client_certificate_request.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/android/tab_model/tab_model_jni_bridge.cc View 6 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/ui/android/toolbar/toolbar_model_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/usb_chooser_dialog_android.cc View 1 7 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/ui/android/website_settings_popup_android.cc View 1 3 chunks +4 lines, -7 lines 0 comments Download
M components/cronet/android/chromium_url_request.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M components/cronet/android/cronet_upload_data_stream_adapter.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/cronet/android/test/sdch_test_util.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/cronet/android/test/test_upload_data_stream_handler.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M components/dom_distiller/core/distilled_page_prefs_android.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/external_video_surface/browser/android/external_video_surface_container_impl.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M components/gcm_driver/instance_id/instance_id_android.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M components/invalidation/impl/invalidation_service_android.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M components/navigation_interception/intercept_navigation_delegate.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/navigation_interception/navigation_params_android.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M components/policy/core/browser/android/android_combined_policy_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/policy/core/browser/android/policy_converter.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_json/json_sanitizer_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/child_account_info_fetcher_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/variations/android/variations_seed_bridge.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/web_contents_delegate_android/color_chooser_android.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M components/web_contents_delegate_android/validation_message_bubble_android.cc View 2 chunks +8 lines, -15 lines 0 comments Download
M components/web_contents_delegate_android/web_contents_delegate_android.cc View 19 chunks +27 lines, -52 lines 0 comments Download
M components/web_restrictions/browser/web_restrictions_client.cc View 11 chunks +15 lines, -19 lines 0 comments Download
M content/app/android/child_process_service_impl.cc View 3 chunks +10 lines, -17 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_android.cc View 1 15 chunks +38 lines, -52 lines 0 comments Download
M content/browser/android/background_sync_network_observer_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/child_process_launcher_android.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M content/browser/android/content_video_view.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 33 chunks +63 lines, -97 lines 0 comments Download
M content/browser/android/content_view_render_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/date_time_chooser_android.cc View 1 chunk +4 lines, -12 lines 0 comments Download
M content/browser/android/interface_provider_android_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/interface_registry_android_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/android/interstitial_page_delegate_android.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/android/popup_touch_handle_drawable.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M content/browser/android/tracing_controller_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/web_contents_observer_proxy.cc View 15 chunks +25 lines, -30 lines 0 comments Download
M content/browser/device_sensors/sensor_manager_android.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigation_controller_android.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M content/browser/media/android/media_resource_getter_impl.cc View 2 chunks +9 lines, -12 lines 0 comments Download
M content/browser/media/android/media_throttler.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/media/session/media_session_delegate_android.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/mojo/interface_registrar_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_android.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/browser/speech/speech_recognizer_impl_android.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/time_zone_monitor_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 10 chunks +19 lines, -26 lines 0 comments Download
M content/common/android/hash_set.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/common/android/media_metadata_android.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/common/android/resource_request_body_android.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/test/nested_message_pump_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_android.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M content/shell/browser/shell_mojo_test_utils_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_android.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M device/bluetooth/bluetooth_device_android.cc View 4 chunks +9 lines, -12 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_descriptor_android.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_remote_gatt_service_android.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_android.cc View 23 chunks +23 lines, -26 lines 0 comments Download
M device/geolocation/location_api_adapter_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M device/power_save_blocker/power_save_blocker_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/usb/usb_configuration_android.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M device/usb/usb_device_android.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M device/usb/usb_device_handle_android.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M device/usb/usb_endpoint_android.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M device/usb/usb_interface_android.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M device/usb/usb_service_android.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M device/vr/android/cardboard/cardboard_vr_device.cc View 6 chunks +8 lines, -10 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M media/audio/android/audio_record_input.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M media/base/android/media_codec_util.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/base/android/media_drm_bridge.cc View 11 chunks +18 lines, -20 lines 0 comments Download
M media/base/android/media_player_bridge.cc View 16 chunks +30 lines, -34 lines 0 comments Download
M media/base/android/sdk_media_codec_bridge.cc View 19 chunks +52 lines, -57 lines 0 comments Download
M media/capture/content/android/screen_capture_machine_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/capture/video/android/photo_capabilities.cc View 1 1 chunk +14 lines, -23 lines 0 comments Download
M media/capture/video/android/video_capture_device_android.cc View 1 9 chunks +11 lines, -11 lines 0 comments Download
M media/capture/video/android/video_capture_device_factory_android.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M media/midi/midi_device_android.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/midi/midi_input_port_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/midi/midi_manager_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_output_port_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/midi/usb_midi_device_android.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M media/midi/usb_midi_device_factory_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/android/javatests/validation_test_util.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/android/system/base_run_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/system/watcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/android/http_auth_negotiate_android.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M net/android/keystore.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/android/keystore_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/android/network_change_notifier_delegate_android.cc View 4 chunks +9 lines, -13 lines 0 comments Download
M net/android/network_library.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M net/proxy/proxy_config_service_android.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M net/test/embedded_test_server/android/embedded_test_server_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M printing/printing_context_android.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M remoting/client/jni/jni_client.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M remoting/client/jni/jni_display_handler.cc View 1 3 chunks +6 lines, -7 lines 0 comments Download
M remoting/client/jni/jni_gl_display_handler.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M remoting/client/jni/jni_touch_event_data.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M remoting/host/android/jni_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/android/resources/resource_manager_impl.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M ui/android/view_android.cc View 4 chunks +6 lines, -20 lines 0 comments Download
M ui/android/window_android.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M ui/base/clipboard/clipboard_android.cc View 1 3 chunks +6 lines, -7 lines 0 comments Download
M ui/base/l10n/l10n_util_android.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M ui/base/resource/resource_bundle_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/events/android/key_event_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/android/motion_event_android.cc View 7 chunks +19 lines, -19 lines 0 comments Download
M ui/gfx/android/shared_device_display_info.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M ui/gl/android/scoped_java_surface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/android/surface_texture.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M ui/platform_window/android/platform_ime_controller_android.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M ui/platform_window/android/platform_window_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/shell_dialogs/select_file_dialog_android.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
Torne
Ross, does this seem sane? The combination of converting GetApplicationContext and this CL fixes >90% ...
3 years, 12 months ago (2016-08-12 08:39:55 UTC) #7
rmcilroy
Yup, seems sane to me. LGTM, thanks.
3 years, 12 months ago (2016-08-12 09:23:53 UTC) #8
Torne
Hi Ben; this should be the last massive machine-generated refactoring patch for JNI (for a ...
3 years, 12 months ago (2016-08-12 13:05:21 UTC) #10
Ben Goodger (Google)
rs lgtm
3 years, 12 months ago (2016-08-12 14:11:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237943002/20001
3 years, 11 months ago (2016-08-16 13:44:57 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/113074) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2016-08-16 13:48:26 UTC) #16
Torne
Oh wow, the patch got out of date in the 30 minutes since I uploaded ...
3 years, 11 months ago (2016-08-16 13:54:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237943002/40001
3 years, 11 months ago (2016-08-16 13:58:39 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2016-08-16 15:11:08 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2016-08-16 15:12:40 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/948f366645b6e37e2a43bac70c07a8d5c7e592eb
Cr-Commit-Position: refs/heads/master@{#412237}

Powered by Google App Engine
This is Rietveld 408576698