Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed)

Created:
4 years, 5 months ago by ddoman
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -127 lines) Patch
M appengine/cmd/milo/buildbot/pubsub.go View 2 chunks +2 lines, -0 lines 0 comments Download
M appengine/tsmon/global_callback_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M appengine/tsmon/grpc.go View 1 chunk +3 lines, -0 lines 0 comments Download
M appengine/tsmon/middleware_test.go View 1 chunk +3 lines, -1 line 0 comments Download
M appengine/tsmon/standardmetrics.go View 1 chunk +3 lines, -1 line 0 comments Download
M client/cmd/luci_machine_tokend/status.go View 2 chunks +19 lines, -9 lines 0 comments Download
M common/tsmon/callback_test.go View 2 chunks +2 lines, -0 lines 0 comments Download
M common/tsmon/flush_test.go View 4 chunks +4 lines, -0 lines 0 comments Download
M common/tsmon/metric/metric.go View 9 chunks +57 lines, -52 lines 0 comments Download
M common/tsmon/metric/metric_test.go View 9 chunks +16 lines, -16 lines 0 comments Download
M common/tsmon/metric/standard_metrics.go View 9 chunks +11 lines, -1 line 0 comments Download
M common/tsmon/monitor/acq.go View 1 chunk +3 lines, -0 lines 0 comments Download
M common/tsmon/monitor/acq_test.go View 7 chunks +7 lines, -0 lines 0 comments Download
M common/tsmon/runtimestats/runtimestats.go View 1 chunk +19 lines, -18 lines 0 comments Download
M common/tsmon/store/inmemory.go View 2 chunks +2 lines, -1 line 0 comments Download
M common/tsmon/store/storetest/testing.go View 18 chunks +83 lines, -25 lines 0 comments Download
M common/tsmon/types/cell.go View 2 chunks +6 lines, -0 lines 0 comments Download
M common/tsmon/types/metric.go View 1 chunk +1 line, -0 lines 0 comments Download
A common/tsmon/types/metricdataunits.go View 1 chunk +89 lines, -0 lines 0 comments Download
M server/cmd/logdog_archivist/main.go View 2 chunks +2 lines, -0 lines 0 comments Download
M server/cmd/logdog_collector/main.go View 1 2 chunks +3 lines, -0 lines 0 comments Download
M server/internal/logdog/archivist/archivist.go View 6 chunks +6 lines, -0 lines 0 comments Download
M server/internal/logdog/collector/collector.go View 3 chunks +10 lines, -2 lines 0 comments Download
M server/internal/logdog/collector/coordinator/cache.go View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ddoman
4 years, 5 months ago (2016-07-06 05:07:41 UTC) #1
Sergey Berezin
LGTM + one small comment. Thanks! https://codereview.chromium.org/2123853002/diff/1/server/cmd/logdog_collector/main.go File server/cmd/logdog_collector/main.go (right): https://codereview.chromium.org/2123853002/diff/1/server/cmd/logdog_collector/main.go#newcode53 server/cmd/logdog_collector/main.go:53: types.MetricMetadata{}, Should this ...
4 years, 5 months ago (2016-07-06 21:39:12 UTC) #3
ddoman
https://codereview.chromium.org/2123853002/diff/1/server/cmd/logdog_collector/main.go File server/cmd/logdog_collector/main.go (right): https://codereview.chromium.org/2123853002/diff/1/server/cmd/logdog_collector/main.go#newcode53 server/cmd/logdog_collector/main.go:53: types.MetricMetadata{}, On 2016/07/06 21:39:12, Sergey Berezin wrote: > Should ...
4 years, 5 months ago (2016-07-07 04:47:57 UTC) #4
Sergey Berezin
LGTM, feel free to CQ this. Thanks!
4 years, 5 months ago (2016-07-08 17:16:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123853002/20001
4 years, 5 months ago (2016-07-11 00:36:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://github.com/luci/luci-go/commit/dfa8e6dcf7d6bf5215edb7a44453c502085a7f90
4 years, 5 months ago (2016-07-11 00:45:05 UTC) #9
ddoman
4 years, 5 months ago (2016-07-11 03:45:59 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2140473002/ by ddoman@chromium.org.

The reason for reverting is: Revert this back temporarily due to
https://codereview.chromium.org/2125943003

2125943003 has a dependency on the changes at this CL, but this CL needs to be
deployed first in order for 2125943003 to be committed.

Revert this CL and patch it back when it is ready to deploy..

Powered by Google App Engine
This is Rietveld 408576698