|
|
DescriptionUpdated moniroting/proxy and cloudtail/client with tsmon's unit annotation supports.
This CL has dependencies onto the changes at the following CL:
https://codereview.chromium.org/2123853002
R=agable@chromium.org, dsansome@chromium.org, sergeyberezin@chromium.org
BUG=623854
Committed: https://chromium.googlesource.com/infra/infra/+/72cebcebc359306cdd0ba9008cd07ddbaa3aa1d0
Patch Set 1 #Patch Set 2 : Sync-ing to master to catch up the changes made at chrome-cl 2123853002 #Patch Set 3 : Update DEPS with the revision of luci-go with crrev.com/2123853002 #
Messages
Total messages: 33 (23 generated)
Description was changed from ========== Updated moniroting/proxy and cloudtail/client with tsmon's unit annotation supports. This CL has dependencies onto the changes at the following CL: https://codereview.chromium.org/2123853002 R=agable@chromium.org, dsansome@chromium.org, sergeyberezin@chromium.org BUG=623854 ========== to ========== Updated moniroting/proxy and cloudtail/client with tsmon's unit annotation supports. This CL has dependencies onto the changes at the following CL: https://codereview.chromium.org/2123853002 R=agable@chromium.org, dsansome@chromium.org, sergeyberezin@chromium.org BUG=623854 ==========
LGTM, thanks! (obviously, it can't land yet, but feel free to CQ it once all dependencies are satisfied)
The CQ bit was checked by ddoman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Infra Win Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Win%20Tester/bu...)
The CQ bit was checked by ddoman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by ddoman@chromium.org
The CQ bit was checked by ddoman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Infra Win Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Win%20Tester/bu...)
The CQ bit was unchecked by ddoman@chromium.org
The CQ bit was checked by ddoman@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Infra Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/bu...)
The CQ bit was checked by ddoman@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Infra Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/bu...)
Now that http://crrev.com/2123853002 landed, you need to bump the version of luci-go in the top-level DEPS file, and add it to this very CL. This way, luci-go roll and the necessary backwards-incompatible updates will go in a single CL and will not break any code here.
The CQ bit was checked by ddoman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Great, LGTM! Feel free to CQ this. It seems the common HTTP metrics (ts_mon/common/http_metrics.py) are not updated with units, and other metrics I believe are service-specific. So we can take time redeploying the services one by one without any massive inconsistencies.
The CQ bit was checked by ddoman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Updated moniroting/proxy and cloudtail/client with tsmon's unit annotation supports. This CL has dependencies onto the changes at the following CL: https://codereview.chromium.org/2123853002 R=agable@chromium.org, dsansome@chromium.org, sergeyberezin@chromium.org BUG=623854 ========== to ========== Updated moniroting/proxy and cloudtail/client with tsmon's unit annotation supports. This CL has dependencies onto the changes at the following CL: https://codereview.chromium.org/2123853002 R=agable@chromium.org, dsansome@chromium.org, sergeyberezin@chromium.org BUG=623854 Committed: https://chromium.googlesource.com/infra/infra/+/72cebcebc359306cdd0ba9008cd07... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/infra/infra/+/72cebcebc359306cdd0ba9008cd07... |