Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2125943003: Updated moniroting/proxy and cloudtail/client with tsmon's unit annotation supports. (Closed)

Created:
4 years, 5 months ago by ddoman
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Updated moniroting/proxy and cloudtail/client with tsmon's unit annotation supports. This CL has dependencies onto the changes at the following CL: https://codereview.chromium.org/2123853002 R=agable@chromium.org, dsansome@chromium.org, sergeyberezin@chromium.org BUG=623854 Committed: https://chromium.googlesource.com/infra/infra/+/72cebcebc359306cdd0ba9008cd07ddbaa3aa1d0

Patch Set 1 #

Patch Set 2 : Sync-ing to master to catch up the changes made at chrome-cl 2123853002 #

Patch Set 3 : Update DEPS with the revision of luci-go with crrev.com/2123853002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/monitoring/proxy/main.go View 2 chunks +3 lines, -0 lines 0 comments Download
M go/src/infra/monitoring/proxy/pubsub.go View 2 chunks +5 lines, -0 lines 0 comments Download
M go/src/infra/tools/cloudtail/client.go View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (23 generated)
ddoman
4 years, 5 months ago (2016-07-07 05:03:48 UTC) #1
Sergey Berezin
LGTM, thanks! (obviously, it can't land yet, but feel free to CQ it once all ...
4 years, 5 months ago (2016-07-08 17:19:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125943003/1
4 years, 5 months ago (2016-07-11 00:47:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Infra Win Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Win%20Tester/builds/2890)
4 years, 5 months ago (2016-07-11 00:56:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125943003/1
4 years, 5 months ago (2016-07-11 02:00:52 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: Infra Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/builds/2903)
4 years, 5 months ago (2016-07-11 02:08:52 UTC) #19
Sergey Berezin
Now that http://crrev.com/2123853002 landed, you need to bump the version of luci-go in the top-level ...
4 years, 5 months ago (2016-07-11 18:13:12 UTC) #24
Sergey Berezin
Great, LGTM! Feel free to CQ this. It seems the common HTTP metrics (ts_mon/common/http_metrics.py) are ...
4 years, 5 months ago (2016-07-12 22:25:47 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2125943003/40001
4 years, 5 months ago (2016-07-12 23:24:46 UTC) #31
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 23:26:42 UTC) #33
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/72cebcebc359306cdd0ba9008cd07...

Powered by Google App Engine
This is Rietveld 408576698