common/tsmon/callback_test.go - Issue 2123853002: Added unit annotation supports onto tsmon in go.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/tsmon/callback_test.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: common/tsmon/callback_test.go

diff --git a/common/tsmon/callback_test.go b/common/tsmon/callback_test.go

index 657734dab8063998eac82d627ccdb0e311a1e815..cb78c72865a4436db03423e4b9e9598544510efe 100644

--- a/common/tsmon/callback_test.go

+++ b/common/tsmon/callback_test.go

@@ -35,6 +35,7 @@ func TestCallbacks(t *testing.T) {

Fields: []field.Field{},

ValueType: types.StringType,

+ types.MetricMetadata{},

types.CellData{

FieldVals: []interface{}{},

ResetTime: time.Unix(1234, 1000),

@@ -53,6 +54,7 @@ func TestCallbacks(t *testing.T) {