appengine/cmd/milo/buildbot/pubsub.go - Issue 2123853002: Added unit annotation supports onto tsmon in go.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/cmd/milo/buildbot/pubsub.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/cmd/milo/buildbot/pubsub.go

diff --git a/appengine/cmd/milo/buildbot/pubsub.go b/appengine/cmd/milo/buildbot/pubsub.go

index 47d7ad88b4f0e16f5c0b64459c09a56acce42bb7..3a21affb3512ed1949cb54160210f0897df5a67a 100644

--- a/appengine/cmd/milo/buildbot/pubsub.go

+++ b/appengine/cmd/milo/buildbot/pubsub.go

@@ -22,6 +22,7 @@ import (

"github.com/luci/luci-go/common/tsmon/field"

"github.com/luci/luci-go/common/tsmon/metric"

+ "github.com/luci/luci-go/common/tsmon/types"

)

var (

@@ -33,6 +34,7 @@ var (

buildCounter = metric.NewCounter(

"luci/milo/buildbot_pubsub/builds",

"The number of buildbot builds received by Milo from PubSub",

+ types.MetricMetadata{},

field.Bool("internal"),

field.String("master"),

field.String("builder"),

« no previous file with comments | « no previous file | appengine/tsmon/global_callback_test.go » ('j') | no next file with comments »