appengine/tsmon/grpc.go - Issue 2123853002: Added unit annotation supports onto tsmon in go.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/tsmon/grpc.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/tsmon/grpc.go

diff --git a/appengine/tsmon/grpc.go b/appengine/tsmon/grpc.go

index 4e0768863770aa1e4f32465d4f038e23b754add0..84772cc02f75e5a91066335820253b83651d458d 100644

--- a/appengine/tsmon/grpc.go

+++ b/appengine/tsmon/grpc.go

@@ -14,18 +14,21 @@ import (

"github.com/luci/luci-go/common/tsmon/distribution"

"github.com/luci/luci-go/common/tsmon/field"

"github.com/luci/luci-go/common/tsmon/metric"

+ "github.com/luci/luci-go/common/tsmon/types"

)

var (

grpcServerCount = metric.NewCounter(

"grpc/server/count",

"Total number of RPCs.",

+ types.MetricMetadata{},

field.String("method"), // full name of the grpc method

field.Int("code")) // grpc.Code of the result

grpcServerDuration = metric.NewCumulativeDistribution(

"grpc/server/duration",

"Distribution of server-side RPC duration (in milliseconds).",

+ types.MetricMetadata{},

distribution.DefaultBucketer,

field.String("method"), // full name of the grpc method

field.Int("code")) // grpc.Code of the result

« no previous file with comments | « appengine/tsmon/global_callback_test.go ('k') | appengine/tsmon/middleware_test.go » ('j') | no next file with comments »