server/internal/logdog/collector/coordinator/cache.go - Issue 2123853002: Added unit annotation supports onto tsmon in go.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: server/internal/logdog/collector/coordinator/cache.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: server/internal/logdog/collector/coordinator/cache.go

diff --git a/server/internal/logdog/collector/coordinator/cache.go b/server/internal/logdog/collector/coordinator/cache.go

index 06f8b3056b01fdfe05738da71689bf338801e259..54f2e6131c8c2077749caa80419f91739a207a42 100644

--- a/server/internal/logdog/collector/coordinator/cache.go

+++ b/server/internal/logdog/collector/coordinator/cache.go

@@ -17,6 +17,7 @@ import (

"github.com/luci/luci-go/common/promise"

"github.com/luci/luci-go/common/tsmon/field"

"github.com/luci/luci-go/common/tsmon/metric"

+ tsmon_types "github.com/luci/luci-go/common/tsmon/types"

"golang.org/x/net/context"

)

@@ -31,6 +32,7 @@ const (

var (

tsCache = metric.NewCounter("logdog/collector/coordinator/cache",

"Metrics for cache uses, tracking hits and misses.",

+ tsmon_types.MetricMetadata{},

field.Bool("hit"))

)

« no previous file with comments | « server/internal/logdog/collector/collector.go ('k') | no next file » | no next file with comments »