Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: common/tsmon/runtimestats/runtimestats.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « common/tsmon/monitor/acq_test.go ('k') | common/tsmon/store/inmemory.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common/tsmon/runtimestats/runtimestats.go
diff --git a/common/tsmon/runtimestats/runtimestats.go b/common/tsmon/runtimestats/runtimestats.go
index a9b76203badf584aab4f0f7461c67949d4f160be..59e0acbb2ac2d8411edf1f979f19af8ab7d48cb9 100644
--- a/common/tsmon/runtimestats/runtimestats.go
+++ b/common/tsmon/runtimestats/runtimestats.go
@@ -17,33 +17,34 @@ import (
"golang.org/x/net/context"
"github.com/luci/luci-go/common/tsmon/metric"
+ "github.com/luci/luci-go/common/tsmon/types"
)
var (
// Some per-process memory allocator stats.
// See https://golang.org/pkg/runtime/#MemStats
- MemAlloc = metric.NewInt("go/mem/alloc", "Bytes allocated and not yet freed.")
- MemTotalAlloc = metric.NewCounter("go/mem/total_alloc", "Bytes allocated (even if freed).")
- MemMallocs = metric.NewCounter("go/mem/mallocs", "Number of mallocs.")
- MemFrees = metric.NewCounter("go/mem/frees", "Number of frees.")
- MemNextGC = metric.NewInt("go/mem/next_gc", "Next GC will happen when go/mem/alloc > this amount.")
- MemNumGC = metric.NewCounter("go/mem/num_gc", "Number of garbage collections.")
- MemPauseTotal = metric.NewCounter("go/mem/pause_total", "Total GC pause, in microseconds.")
- MemHeapSys = metric.NewInt("go/mem/heap_sys", "Bytes obtained from system.")
- MemHeapIdle = metric.NewInt("go/mem/heap_idle", "Bytes in idle spans.")
- MemHeapInuse = metric.NewInt("go/mem/heap_in_use", "Bytes in non-idle span.")
- MemHeapObjects = metric.NewCounter("go/mem/heap_objects", "total number of allocated objects.")
- MemStackInuse = metric.NewInt("go/mem/stack_in_use", "Bytes used by stack allocator.")
- MemStackSys = metric.NewInt("go/mem/stack_in_sys", "Bytes allocated to stack allocator.")
- MemMSpanInuse = metric.NewInt("go/mem/mspan_in_use", "Bytes used by mspan structures.")
- MemMSpanSys = metric.NewInt("go/mem/mspan_in_sys", "Bytes allocated to mspan structures.")
- MemMCacheInuse = metric.NewInt("go/mem/mcache_in_use", "Bytes used by mcache structures.")
- MemMCacheSys = metric.NewInt("go/mem/mcache_in_sys", "Bytes allocated to mcache structures.")
+ MemAlloc = metric.NewInt("go/mem/alloc", "Bytes allocated and not yet freed.", types.MetricMetadata{types.Bytes})
+ MemTotalAlloc = metric.NewCounter("go/mem/total_alloc", "Bytes allocated (even if freed).", types.MetricMetadata{types.Bytes})
+ MemMallocs = metric.NewCounter("go/mem/mallocs", "Number of mallocs.", types.MetricMetadata{})
+ MemFrees = metric.NewCounter("go/mem/frees", "Number of frees.", types.MetricMetadata{})
+ MemNextGC = metric.NewInt("go/mem/next_gc", "Next GC will happen when go/mem/alloc > this amount.", types.MetricMetadata{})
+ MemNumGC = metric.NewCounter("go/mem/num_gc", "Number of garbage collections.", types.MetricMetadata{})
+ MemPauseTotal = metric.NewCounter("go/mem/pause_total", "Total GC pause, in microseconds.", types.MetricMetadata{})
+ MemHeapSys = metric.NewInt("go/mem/heap_sys", "Bytes obtained from system.", types.MetricMetadata{types.Bytes})
+ MemHeapIdle = metric.NewInt("go/mem/heap_idle", "Bytes in idle spans.", types.MetricMetadata{types.Bytes})
+ MemHeapInuse = metric.NewInt("go/mem/heap_in_use", "Bytes in non-idle span.", types.MetricMetadata{types.Bytes})
+ MemHeapObjects = metric.NewCounter("go/mem/heap_objects", "total number of allocated objects.", types.MetricMetadata{})
+ MemStackInuse = metric.NewInt("go/mem/stack_in_use", "Bytes used by stack allocator.", types.MetricMetadata{types.Bytes})
+ MemStackSys = metric.NewInt("go/mem/stack_in_sys", "Bytes allocated to stack allocator.", types.MetricMetadata{types.Bytes})
+ MemMSpanInuse = metric.NewInt("go/mem/mspan_in_use", "Bytes used by mspan structures.", types.MetricMetadata{types.Bytes})
+ MemMSpanSys = metric.NewInt("go/mem/mspan_in_sys", "Bytes allocated to mspan structures.", types.MetricMetadata{types.Bytes})
+ MemMCacheInuse = metric.NewInt("go/mem/mcache_in_use", "Bytes used by mcache structures.", types.MetricMetadata{types.Bytes})
+ MemMCacheSys = metric.NewInt("go/mem/mcache_in_sys", "Bytes allocated to mcache structures.", types.MetricMetadata{types.Bytes})
// Other runtime stats.
- GoroutineNum = metric.NewInt("go/goroutine/num", "The number of goroutines that currently exist.")
+ GoroutineNum = metric.NewInt("go/goroutine/num", "The number of goroutines that currently exist.", types.MetricMetadata{})
)
// Report updates runtime stats metrics.
« no previous file with comments | « common/tsmon/monitor/acq_test.go ('k') | common/tsmon/store/inmemory.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698