common/tsmon/types/metric.go - Issue 2123853002: Added unit annotation supports onto tsmon in go.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/tsmon/types/metric.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: common/tsmon/types/metric.go

diff --git a/common/tsmon/types/metric.go b/common/tsmon/types/metric.go

index 91a89998485c89b1a73d506600fd384f7bf6079a..fca2c3a5b344f981100452df0442e5e439b3c657 100644

--- a/common/tsmon/types/metric.go

+++ b/common/tsmon/types/metric.go

@@ -14,6 +14,7 @@ import (

// Concrete types are defined in the "metrics" package.

type Metric interface {

Info() MetricInfo

+ Metadata() MetricMetadata

// SetFixedResetTime overrides the reset time for this metric. Usually cells

// take the current time when they're first assigned a value, but it can be

« no previous file with comments | « common/tsmon/types/cell.go ('k') | common/tsmon/types/metricdataunits.go » ('j') | no next file with comments »