Added unit annotation supports onto tsmon in go.

server/cmd/logdog_collector/main.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package main
 
 import (
         "fmt"
         "time"
 
         "github.com/luci/luci-go/common/auth"
         "github.com/luci/luci-go/common/clock"
         "github.com/luci/luci-go/common/errors"
         gcps "github.com/luci/luci-go/common/gcloud/pubsub"
         log "github.com/luci/luci-go/common/logging"
         "github.com/luci/luci-go/common/parallel"
         "github.com/luci/luci-go/common/tsmon/distribution"
         "github.com/luci/luci-go/common/tsmon/field"
         "github.com/luci/luci-go/common/tsmon/metric"
+        "github.com/luci/luci-go/common/tsmon/types"
         "github.com/luci/luci-go/server/internal/logdog/collector"
         "github.com/luci/luci-go/server/internal/logdog/collector/coordinator"
         "github.com/luci/luci-go/server/internal/logdog/service"
         "golang.org/x/net/context"
         "google.golang.org/cloud"
         "google.golang.org/cloud/pubsub"
 )
 
 var (
         errInvalidConfig = errors.New("invalid configuration")
 )
 
 const (
         pubsubPullErrorDelay = 10 * time.Second
 )
 
 // Metrics.
 var (
         // tsPubsubCount counts the number of Pub/Sub messages processed by the
         // Archivist.
         //
         // Result tracks the outcome of each message, either "success", "failure", or
         // "transient_failure".
         tsPubsubCount = metric.NewCounter("logdog/collector/subscription/count",
                 "The number of Pub/Sub messages pulled.",
+                types.MetricMetadata{},
                 field.String("result"))
 
         // tsTaskProcessingTime tracks the amount of time a single subscription
         // message takes to process, in milliseconds.
         tsTaskProcessingTime = metric.NewCumulativeDistribution("logdog/collector/subscription/processing_time_ms",
                 "Amount of time in milliseconds that a single Pub/Sub message takes to process.",
+                types.MetricMetadata{},

[Sergey Berezin, 2016/07/06 21:39:12]

Should this be Units: types.Milliseconds ?

[ddoman, 2016/07/07 04:47:57]

Good catch!
Fixed.

                 distribution.DefaultBucketer)
 )
 
 // application is the Collector application state.
 type application struct {
         service.Service
 }
 
 // run is the main execution function.
 func (a *application) runCollector(c context.Context) error {
@@ skipping 159 matching lines @@
 
 // Entry point.
 func main() {
         a := application{
                 Service: service.Service{
                         Name: "collector",
                 },
         }
         a.Run(context.Background(), a.runCollector)
 }