appengine/tsmon/middleware_test.go - Issue 2123853002: Added unit annotation supports onto tsmon in go.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/tsmon/middleware_test.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/tsmon/middleware_test.go

diff --git a/appengine/tsmon/middleware_test.go b/appengine/tsmon/middleware_test.go

index 6fe295ea4f633de6d95b014017fc3f624ad4dc73..d88b74318634c54ca2d1742667aa47c52b22f7b7 100644

--- a/appengine/tsmon/middleware_test.go

+++ b/appengine/tsmon/middleware_test.go

@@ -25,7 +25,9 @@ import (

func TestMiddleware(t *testing.T) {

t.Parallel()

- metric := &storetest.FakeMetric{"m", "", []field.Field{}, types.CumulativeIntType}

+ metric := &storetest.FakeMetric{

+ types.MetricInfo{"m", "", []field.Field{}, types.CumulativeIntType},

+ types.MetricMetadata{}}

f := func(c *router.Context) {

So(store.IsNilStore(tsmon.Store(c.Context)), ShouldBeFalse)

« no previous file with comments | « appengine/tsmon/grpc.go ('k') | appengine/tsmon/standardmetrics.go » ('j') | no next file with comments »