Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: common/tsmon/monitor/acq_test.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « common/tsmon/monitor/acq.go ('k') | common/tsmon/runtimestats/runtimestats.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common/tsmon/monitor/acq_test.go
diff --git a/common/tsmon/monitor/acq_test.go b/common/tsmon/monitor/acq_test.go
index 06ce6322fd1db88570f054c83830df12eef49437..d9c4e05527171219df9c01268b2beda544546db5 100644
--- a/common/tsmon/monitor/acq_test.go
+++ b/common/tsmon/monitor/acq_test.go
@@ -137,6 +137,7 @@ func TestSerializeCell(t *testing.T) {
Fields: []field.Field{},
ValueType: types.NonCumulativeIntType,
},
+ types.MetricMetadata{},
types.CellData{
FieldVals: []interface{}{},
Target: &target.Task{},
@@ -162,6 +163,7 @@ func TestSerializeCell(t *testing.T) {
Fields: []field.Field{},
ValueType: types.CumulativeIntType,
},
+ types.MetricMetadata{},
types.CellData{
FieldVals: []interface{}{},
Target: &target.Task{},
@@ -188,6 +190,7 @@ func TestSerializeCell(t *testing.T) {
Fields: []field.Field{},
ValueType: types.NonCumulativeFloatType,
},
+ types.MetricMetadata{},
types.CellData{
FieldVals: []interface{}{},
Target: &target.Task{},
@@ -213,6 +216,7 @@ func TestSerializeCell(t *testing.T) {
Fields: []field.Field{},
ValueType: types.CumulativeFloatType,
},
+ types.MetricMetadata{},
types.CellData{
FieldVals: []interface{}{},
Target: &target.Task{},
@@ -239,6 +243,7 @@ func TestSerializeCell(t *testing.T) {
Fields: []field.Field{},
ValueType: types.StringType,
},
+ types.MetricMetadata{},
types.CellData{
FieldVals: []interface{}{},
Target: &target.Task{},
@@ -264,6 +269,7 @@ func TestSerializeCell(t *testing.T) {
Fields: []field.Field{},
ValueType: types.BoolType,
},
+ types.MetricMetadata{},
types.CellData{
FieldVals: []interface{}{},
Target: &target.Task{},
@@ -294,6 +300,7 @@ func TestSerializeCell(t *testing.T) {
Fields: []field.Field{},
ValueType: types.NonCumulativeIntType,
},
+ types.MetricMetadata{},
types.CellData{
FieldVals: []interface{}{},
Target: &target,
« no previous file with comments | « common/tsmon/monitor/acq.go ('k') | common/tsmon/runtimestats/runtimestats.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698