common/tsmon/metric/metric_test.go - Issue 2123853002: Added unit annotation supports onto tsmon in go.

Unified Diff: common/tsmon/metric/metric_test.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: common/tsmon/metric/metric_test.go

diff --git a/common/tsmon/metric/metric_test.go b/common/tsmon/metric/metric_test.go

index 3f1e8dcdb303c31970ceb3b090ec75ec6f1bb147..19aa95edd2c0b4d2b951d4fa9d62224aca0f4573 100644

--- a/common/tsmon/metric/metric_test.go

+++ b/common/tsmon/metric/metric_test.go

@@ -30,7 +30,7 @@ func makeContext() context.Context {

func TestMetrics(t *testing.T) {

Convey("Int", t, func() {

c := makeContext()

- m := NewIntIn(c, "foo", "description")

+ m := NewIntIn(c, "foo", "description", types.MetricMetadata{})

v, err := m.Get(c)

So(v, ShouldEqual, 0)

@@ -49,12 +49,12 @@ func TestMetrics(t *testing.T) {

err = m.Set(c, 42, "field")

So(err, ShouldNotBeNil)

- So(func() { NewIntIn(c, "foo", "description") }, ShouldPanic)

+ So(func() { NewIntIn(c, "foo", "description", types.MetricMetadata{}) }, ShouldPanic)

})

Convey("Counter", t, func() {

c := makeContext()

- m := NewCounterIn(c, "foo", "description")

+ m := NewCounterIn(c, "foo", "description", types.MetricMetadata{})

v, err := m.Get(c)

So(v, ShouldEqual, 0)

@@ -74,12 +74,12 @@ func TestMetrics(t *testing.T) {

So(v, ShouldEqual, 5)

So(err, ShouldBeNil)

- So(func() { NewCounterIn(c, "foo", "description") }, ShouldPanic)

+ So(func() { NewCounterIn(c, "foo", "description", types.MetricMetadata{}) }, ShouldPanic)

})

Convey("Float", t, func() {

c := makeContext()

- m := NewFloatIn(c, "foo", "description")

+ m := NewFloatIn(c, "foo", "description", types.MetricMetadata{})

v, err := m.Get(c)

So(v, ShouldAlmostEqual, 0.0)

@@ -98,12 +98,12 @@ func TestMetrics(t *testing.T) {

err = m.Set(c, 42.3, "field")

So(err, ShouldNotBeNil)

- So(func() { NewFloatIn(c, "foo", "description") }, ShouldPanic)

+ So(func() { NewFloatIn(c, "foo", "description", types.MetricMetadata{}) }, ShouldPanic)

})

Convey("FloatCounter", t, func() {

c := makeContext()

- m := NewFloatCounterIn(c, "foo", "description")

+ m := NewFloatCounterIn(c, "foo", "description", types.MetricMetadata{})

v, err := m.Get(c)

So(v, ShouldAlmostEqual, 0.0)

@@ -123,12 +123,12 @@ func TestMetrics(t *testing.T) {

So(v, ShouldAlmostEqual, 5.3)

So(err, ShouldBeNil)

- So(func() { NewFloatCounterIn(c, "foo", "description") }, ShouldPanic)

+ So(func() { NewFloatCounterIn(c, "foo", "description", types.MetricMetadata{}) }, ShouldPanic)

})

Convey("String", t, func() {

c := makeContext()

- m := NewStringIn(c, "foo", "description")

+ m := NewStringIn(c, "foo", "description", types.MetricMetadata{})

v, err := m.Get(c)

So(v, ShouldEqual, "")

@@ -147,12 +147,12 @@ func TestMetrics(t *testing.T) {

err = m.Set(c, "hello", "field")

So(err, ShouldNotBeNil)

- So(func() { NewStringIn(c, "foo", "description") }, ShouldPanic)

+ So(func() { NewStringIn(c, "foo", "description", types.MetricMetadata{}) }, ShouldPanic)

})

Convey("Bool", t, func() {

c := makeContext()

- m := NewBoolIn(c, "foo", "description")

+ m := NewBoolIn(c, "foo", "description", types.MetricMetadata{})

v, err := m.Get(c)

So(v, ShouldEqual, false)

@@ -171,12 +171,12 @@ func TestMetrics(t *testing.T) {

err = m.Set(c, true, "field")

So(err, ShouldNotBeNil)

- So(func() { NewBoolIn(c, "foo", "description") }, ShouldPanic)

+ So(func() { NewBoolIn(c, "foo", "description", types.MetricMetadata{}) }, ShouldPanic)

})

Convey("CumulativeDistribution", t, func() {

c := makeContext()

- m := NewCumulativeDistributionIn(c, "foo", "description", distribution.FixedWidthBucketer(10, 20))

+ m := NewCumulativeDistributionIn(c, "foo", "description", types.MetricMetadata{}, distribution.FixedWidthBucketer(10, 20))

v, err := m.Get(c)

So(v, ShouldBeNil)

@@ -200,12 +200,12 @@ func TestMetrics(t *testing.T) {

So(v.Count(), ShouldEqual, 1)

So(err, ShouldBeNil)

- So(func() { NewCumulativeDistributionIn(c, "foo", "description", m.Bucketer()) }, ShouldPanic)

+ So(func() { NewCumulativeDistributionIn(c, "foo", "description", types.MetricMetadata{}, m.Bucketer()) }, ShouldPanic)

})

Convey("NonCumulativeDistribution", t, func() {

c := makeContext()

- m := NewNonCumulativeDistributionIn(c, "foo", "description", distribution.FixedWidthBucketer(10, 20))

+ m := NewNonCumulativeDistributionIn(c, "foo", "description", types.MetricMetadata{}, distribution.FixedWidthBucketer(10, 20))

v, err := m.Get(c)

So(v, ShouldBeNil)

@@ -231,6 +231,6 @@ func TestMetrics(t *testing.T) {

So(v.Count(), ShouldEqual, 1)

So(err, ShouldBeNil)

- So(func() { NewNonCumulativeDistributionIn(c, "foo", "description", m.Bucketer()) }, ShouldPanic)

+ So(func() { NewNonCumulativeDistributionIn(c, "foo", "description", types.MetricMetadata{}, m.Bucketer()) }, ShouldPanic)

})

}

« no previous file with comments | « common/tsmon/metric/metric.go ('k') | common/tsmon/metric/standard_metrics.go » ('j') | no next file with comments »