Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: common/tsmon/types/cell.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « common/tsmon/store/storetest/testing.go ('k') | common/tsmon/types/metric.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common/tsmon/types/cell.go
diff --git a/common/tsmon/types/cell.go b/common/tsmon/types/cell.go
index 410757d72f7090feeebafb41f14a0ecced99f94c..7712103f150237f910dc67c58fdd048b9080fc2f 100644
--- a/common/tsmon/types/cell.go
+++ b/common/tsmon/types/cell.go
@@ -16,6 +16,7 @@ import (
// type.
type Cell struct {
MetricInfo
+ MetricMetadata
CellData
}
@@ -27,6 +28,11 @@ type MetricInfo struct {
ValueType ValueType
}
+// MetricMetadata contains user-provided metadata for a metric.
+type MetricMetadata struct {
+ Units MetricDataUnits // the unit of recorded data for a given metric.
+}
+
// CellData contains the value of a single cell.
type CellData struct {
FieldVals []interface{}
« no previous file with comments | « common/tsmon/store/storetest/testing.go ('k') | common/tsmon/types/metric.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698