Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: server/internal/logdog/collector/collector.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: server/internal/logdog/collector/collector.go
diff --git a/server/internal/logdog/collector/collector.go b/server/internal/logdog/collector/collector.go
index 04b0f0bf88d116707915e6f2885540286076c013..dbeb24b186457fc64d32e5f0904d7694950b8b7f 100644
--- a/server/internal/logdog/collector/collector.go
+++ b/server/internal/logdog/collector/collector.go
@@ -20,6 +20,7 @@ import (
"github.com/luci/luci-go/common/tsmon/distribution"
"github.com/luci/luci-go/common/tsmon/field"
"github.com/luci/luci-go/common/tsmon/metric"
+ tsmon_types "github.com/luci/luci-go/common/tsmon/types"
"github.com/luci/luci-go/server/internal/logdog/collector/coordinator"
"github.com/luci/luci-go/server/logdog/storage"
"golang.org/x/net/context"
@@ -35,20 +36,24 @@ var (
// tsBundles tracks the total number of logpb.ButlerLogBundle entries that
// have been submitted for collection.
tsBundles = metric.NewCounter("logdog/collector/bundles",
- "The number of individual log entry bundles that have been ingested.")
+ "The number of individual log entry bundles that have been ingested.",
+ tsmon_types.MetricMetadata{})
// tsLogs tracks the number of logpb.LogEntry entries that have been
// written to intermediate storage.
tsLogs = metric.NewCounter("logdog/collector/logs",
- "The number of individual log entries that have been ingested.")
+ "The number of individual log entries that have been ingested.",
+ tsmon_types.MetricMetadata{})
// tsBundleSize tracks the size, in bytes, of a given log bundle.
tsBundleSize = metric.NewCumulativeDistribution("logdog/collector/bundle/size",
"The size (in bytes) of the bundle.",
+ tsmon_types.MetricMetadata{Units: tsmon_types.Bytes},
distribution.DefaultBucketer)
// tsBundleEntriesPerBundle tracks the number of ButlerLogBundle.Entry entries
// in each bundle that have been collected.
tsBundleEntriesPerBundle = metric.NewCumulativeDistribution("logdog/collector/bundle/entries_per_bundle",
"The number of log bundle entries per bundle.",
+ tsmon_types.MetricMetadata{},
distribution.DefaultBucketer)
// tsBundleEntries tracks the total number of ButlerLogBundle.Entry entries
@@ -57,16 +62,19 @@ var (
// The "stream" field is the type of log stream for each tracked bundle entry.
tsBundleEntries = metric.NewCounter("logdog/collector/bundle/entries",
"The number of Butler bundle entries pulled.",
+ tsmon_types.MetricMetadata{},
field.String("stream"))
// tsBundleEntryLogs tracks the number of LogEntry ingested per bundle.
//
// The "stream" field is the type of log stream.
tsBundleEntryLogs = metric.NewCumulativeDistribution("logdog/collector/bundle/entry/logs",
"The number of log entries per bundle.",
+ tsmon_types.MetricMetadata{},
distribution.DefaultBucketer,
field.String("stream"))
tsBundleEntryProcessingTime = metric.NewCumulativeDistribution("logdog/collector/bundle/entry/processing_time_ms",
"The amount of time in milliseconds that a bundle entry takes to process.",
+ tsmon_types.MetricMetadata{Units: tsmon_types.Milliseconds},
distribution.DefaultBucketer,
field.String("stream"))
)
« no previous file with comments | « server/internal/logdog/archivist/archivist.go ('k') | server/internal/logdog/collector/coordinator/cache.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698