appengine/tsmon/global_callback_test.go - Issue 2123853002: Added unit annotation supports onto tsmon in go.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/tsmon/global_callback_test.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/tsmon/global_callback_test.go

diff --git a/appengine/tsmon/global_callback_test.go b/appengine/tsmon/global_callback_test.go

index 151da00e9af7ad2eecc3dab67b9ced4bd5a138e5..f0d949f7dccfe44f7507116116bfc7c4f3424b1f 100644

--- a/appengine/tsmon/global_callback_test.go

+++ b/appengine/tsmon/global_callback_test.go

@@ -14,6 +14,7 @@ import (

"github.com/luci/luci-go/common/clock"

"github.com/luci/luci-go/common/tsmon"

"github.com/luci/luci-go/common/tsmon/metric"

+ "github.com/luci/luci-go/common/tsmon/types"

"github.com/luci/luci-go/server/router"

"golang.org/x/net/context"

@@ -46,7 +47,7 @@ func TestGlobalCallbacks(t *testing.T) {

c, _ := buildGAETestContext()

state, mon := buildTestState()

- m := metric.NewCallbackStringIn(c, "foo", "")

+ m := metric.NewCallbackStringIn(c, "foo", "", types.MetricMetadata{})

tsmon.RegisterGlobalCallbackIn(c, func(c context.Context) {

m.Set(c, "bar")

« no previous file with comments | « appengine/cmd/milo/buildbot/pubsub.go ('k') | appengine/tsmon/grpc.go » ('j') | no next file with comments »