server/cmd/logdog_archivist/main.go - Issue 2123853002: Added unit annotation supports onto tsmon in go.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: server/cmd/logdog_archivist/main.go

Issue 2123853002: Added unit annotation supports onto tsmon in go. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master

Patch Set: Specify the unit of logdog/collector/subscription/processing_time_ms with types.Milliseconds Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: server/cmd/logdog_archivist/main.go

diff --git a/server/cmd/logdog_archivist/main.go b/server/cmd/logdog_archivist/main.go

index 1c8894e6fe2a3a406307a6d6d082b639749c881c..ac94e173608d88c7c54fd199130afa84318be2ee 100644

--- a/server/cmd/logdog_archivist/main.go

+++ b/server/cmd/logdog_archivist/main.go

@@ -19,6 +19,7 @@ import (

"github.com/luci/luci-go/common/tsmon/distribution"

"github.com/luci/luci-go/common/tsmon/field"

"github.com/luci/luci-go/common/tsmon/metric"

+ "github.com/luci/luci-go/common/tsmon/types"

"github.com/luci/luci-go/server/internal/logdog/archivist"

"github.com/luci/luci-go/server/internal/logdog/service"

"golang.org/x/net/context"

@@ -36,6 +37,7 @@ var (

// false if it was not.

tsTaskProcessingTime = metric.NewCumulativeDistribution("logdog/archivist/task_processing_time_ms",

"The amount of time (in milliseconds) that a single task takes to process.",

+ types.MetricMetadata{Units: types.Milliseconds},

distribution.DefaultBucketer,

field.Bool("consumed"))

)

« no previous file with comments | « common/tsmon/types/metricdataunits.go ('k') | server/cmd/logdog_collector/main.go » ('j') | no next file with comments »